Summary

Add a new JS bundle for UI elements.

Review Request #12807 — Created Jan. 26, 2023 and submitted Feb. 27, 2023, 8:28 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

As we move things around in the JavaScript codebase, we'd like a place
to put any generic UI widgets. We already have a ui/ directory in the
tree, and this change adds a new bundle for us to use for it.

Testing Done

Loaded a page and saw that /static/rb/js/ui/index.js was included in
the <script> tags.

Commits

Summary	ID
Add a new JS bundle for UI elements. As we move things around in the JavaScript codebase, we'd like a place to put any generic UI widgets. We already have a `ui/` directory in the tree, and this change adds a new bundle for us to use for it. Testing Done: Loaded a page and saw that `/static/rb/js/ui/index.js` was included in the `<script>` tags.	fded8f6e006300d190ac160a96f10a3c082d8d2b

flake8 passed.

JSHint passed.

Change Summary:

Add bundle to test template as well.

Commits:

	Summary	ID
	Add a new JS bundle for UI elements. As we move things around in the JavaScript codebase, we'd like a place to put any generic UI widgets. We already have a `ui/` directory in the tree, and this change adds a new bundle for us to use for it. Testing Done: Loaded a page and saw that `/static/rb/js/ui/index.js` was included in the `<script>` tags.	5840677931f4fdd777599546d0393d5f60ef77f2
	Add a new JS bundle for UI elements. As we move things around in the JavaScript codebase, we'd like a place to put any generic UI widgets. We already have a `ui/` directory in the tree, and this change adds a new bundle for us to use for it. Testing Done: Loaded a page and saw that `/static/rb/js/ui/index.js` was included in the `<script>` tags.	fded8f6e006300d190ac160a96f10a3c082d8d2b

Diff:

Revision 2 (+18 -4)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/templates/js/tests_base.html
	reviewboard/templates/reviews/reviewable_base.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (bfa0b53)