Make the package.json file in Review Board the primary dependency source.
Review Request #12802 — Created Jan. 23, 2023 and submitted
We used to depend fully on Djblets's
list of Node.js packages to install, since we just made use of the basic
static media tooling in Djblets.
This change makes Review Board's
package.jsona primary source of
dependencies. Right now, we just depend on Djblets (via the
symlink set up when setting up a development environment), setting it up
as a Node workspace to make full use of symlinks. Upcoming changes will
move more dependencies into this.
reviewboard/, making it available to
consumers of published packages. We then symlnk to the root of the tree.
These dependencies are reflected into
a new script that is run any time we run
npm install --saveor
npm uninstall --save(if that operation would update
This way, it should be easier to ensure that we have the right
dependencies in the tree for building static media, looking up types, or
linting the files.
setup.py develop. Verified I got a
working tree, which I was able to use to compile a new package, and
could use with upcoming changes that make deeper use of these
npm install --save ...and
uninstall --save ...and verified
Fixed a typo I introduced last-second.
Revision 2 (+15114 -148)
Checks run (2 succeeded)