Summary

Mark Backbone and underscore as externals, not globals.

Review Request #12796 — Created Jan. 20, 2023 and submitted Jan. 25, 2023, 6:14 p.m.

Information

Owner

chipx86

Repository

Spina

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

This updates the Rollup configuration for Spina to take in Backbone
and underscore as externals. This will pass in Backbone and _ in
the UMD wrapper for the module, taking them the root object (such as
window) or from the calling module.

Defining these as externals is important for module resolution, and to
avoid the assumption of what provides these modules.

Testing Done

Verified that the resulting UMD wrapper takes in Backbone and _ as

parameters and that they're populated automatically.
Also verified that I could successfully import these into a module

bundling this with Backbone, and that resolution worked correctly.

Commits

Summary	ID
Mark Backbone and underscore as externals, not globals. This updates the Rollup configuration for Spina to take in `Backbone` and `underscore` as externals. This will pass in `Backbone` and `_` in the UMD wrapper for the module, taking them the root object (such as `window`) or from the calling module. Defining these as externals is important for module resolution, and to avoid the assumption of what provides these modules.	a9722a2a68b376a8463cf423fe9d91be8bc2d36f

Summary

Mark Backbone and underscore as externals, not globals.

This updates the Rollup configuration for Spina to take in `Backbone` and `underscore` as externals. This will pass in `Backbone` and `_` in the UMD wrapper for the module, taking them the root object (such as `window`) or from the calling module. Defining these as externals is important for module resolution, and to avoid the assumption of what provides these modules.

a9722a2a68b376a8463cf423fe9d91be8bc2d36f

flake8 passed.

JSHint passed.

Change Summary:

Removed the dependency on rollup-plugin-external-globals.

Commits:

	Summary	ID
	Mark Backbone and underscore as externals, not globals. This updates the Rollup configuration for Spina to take in `Backbone` and `underscore` as externals. This will pass in `Backbone` and `_` in the UMD wrapper for the module, taking them the root object (such as `window`) or from the calling module. Defining these as externals is important for module resolution, and to avoid the assumption of what provides these modules.	44006851aff9a733a02f7cd2c2ce16c3bb4dfa14
	Mark Backbone and underscore as externals, not globals. This updates the Rollup configuration for Spina to take in `Backbone` and `underscore` as externals. This will pass in `Backbone` and `_` in the UMD wrapper for the module, taking them the root object (such as `window`) or from the calling module. Defining these as externals is important for module resolution, and to avoid the assumption of what provides these modules.	a9722a2a68b376a8463cf423fe9d91be8bc2d36f

Diff:

Revision 2 (+12 -124)

Show changes

	package.json
	package-lock.json
	rollup.config.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed