Update reviewboard.codesafety and reviewboard.registries for type hints.

Review Request #12782 — Created Jan. 11, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

This enables type hints throughout reviewboard.codesafety, and in
reviewboard.registries to support typed registries. This ensures that
callers and implementations agree on types, which is important given
that dictionaries are often passed around.

The change is a precursor to some upcoming work on code safety checkers
for custom Unicode confusable settings.

Unit tests pass on Python 3.7-3.11.

Summary ID
Update reviewboard.codesafety and reviewboard.registries for type hints.
This enables type hints throughout `reviewboard.codesafety`, and in `reviewboard.registries` to support typed registries. This ensures that callers and implementations agree on types, which is important given that dictionaries are often passed around. The change is a precursor to some upcoming work on code safety checkers for custom Unicode confusable settings.
8683294a15e61c299cf6ed8117a5d8028fee374e
Description From Last Updated

Would be clearer to say "A set of warning IDs ..." instead.

maubinmaubin

Probably wanna get rid of the "2. " here

maubinmaubin

Probably wanna get rid of the "3. " here

maubinmaubin
david
  1. Ship It!
  2. 
      
maubin
  1. 
      
  2. reviewboard/codesafety/checkers/base.py (Diff revision 1)
     
     

    Would be clearer to say "A set of warning IDs ..." instead.

  3. Probably wanna get rid of the "2. " here

  4. Probably wanna get rid of the "3. " here

  5. 
      
chipx86
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (a9df20e)
Loading...