Summary

Update reviewboard.codesafety and reviewboard.registries for type hints.

Review Request #12782 — Created Jan. 11, 2023 and submitted Jan. 31, 2023, 1:23 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This enables type hints throughout reviewboard.codesafety, and in
reviewboard.registries to support typed registries. This ensures that
callers and implementations agree on types, which is important given
that dictionaries are often passed around.

The change is a precursor to some upcoming work on code safety checkers
for custom Unicode confusable settings.

Testing Done

Unit tests pass on Python 3.7-3.11.

Commits

Summary	ID
Update reviewboard.codesafety and reviewboard.registries for type hints. This enables type hints throughout `reviewboard.codesafety`, and in `reviewboard.registries` to support typed registries. This ensures that callers and implementations agree on types, which is important given that dictionaries are often passed around. The change is a precursor to some upcoming work on code safety checkers for custom Unicode confusable settings.	8683294a15e61c299cf6ed8117a5d8028fee374e

Summary

Update reviewboard.codesafety and reviewboard.registries for type hints.

This enables type hints throughout `reviewboard.codesafety`, and in `reviewboard.registries` to support typed registries. This ensures that callers and implementations agree on types, which is important given that dictionaries are often passed around. The change is a precursor to some upcoming work on code safety checkers for custom Unicode confusable settings.

8683294a15e61c299cf6ed8117a5d8028fee374e

Issues

Description	From	Last Updated
Would be clearer to say "A set of warning IDs ..." instead.	maubin	Jan. 13, 2023, 5:51 p.m.
Probably wanna get rid of the "2. " here	maubin	Jan. 13, 2023, 5:51 p.m.
Probably wanna get rid of the "3. " here	maubin	Jan. 13, 2023, 5:51 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

reviewboard/codesafety/checkers/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Would be clearer to say "A set of warning IDs ..." instead.
```
reviewboard/codesafety/checkers/trojan_source.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably wanna get rid of the "2. " here
```
reviewboard/codesafety/checkers/trojan_source.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Probably wanna get rid of the "3. " here
```

Change Summary:

Fixed a few documentation issues.

Commits:

	Summary	ID
	Update reviewboard.codesafety and reviewboard.registries for type hints. This enables type hints throughout `reviewboard.codesafety`, and in `reviewboard.registries` to support typed registries. This ensures that callers and implementations agree on types, which is important given that dictionaries are often passed around. The change is a precursor to some upcoming work on code safety checkers for custom Unicode confusable settings.	1bd6ad4d58a468d028cb06cbd13efcae59426fcc
	Update reviewboard.codesafety and reviewboard.registries for type hints. This enables type hints throughout `reviewboard.codesafety`, and in `reviewboard.registries` to support typed registries. This ensures that callers and implementations agree on types, which is important given that dictionaries are often passed around. The change is a precursor to some upcoming work on code safety checkers for custom Unicode confusable settings.	8683294a15e61c299cf6ed8117a5d8028fee374e

Diff:

Revision 2 (+384 -118)

Show changes

	reviewboard/codesafety/checkers/base.py
	reviewboard/codesafety/checkers/registry.py
	reviewboard/codesafety/checkers/trojan_source.py
	reviewboard/codesafety/tests/test_trojan_source_code_safety_checker.py
	reviewboard/registries/registry.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (a9df20e)