flake8
passed.
JSHint
passed.
Update reviewboard.codesafety and reviewboard.registries for type hints.
Review Request #12782 — Created Jan. 11, 2023 and submitted
| Information | |
|---|---|
| chipx86 | |
| Review Board | |
| release-5.0.x | |
| Reviewers | |
| reviewboard | |
This enables type hints throughout
reviewboard.codesafety, and in
reviewboard.registriesto support typed registries. This ensures that
callers and implementations agree on types, which is important given
that dictionaries are often passed around.The change is a precursor to some upcoming work on code safety checkers
for custom Unicode confusable settings.
Unit tests pass on Python 3.7-3.11.
-
-
reviewboard/codesafety/checkers/base.py (Diff revision 1) Would be clearer to say "A set of warning IDs ..." instead.
-
reviewboard/codesafety/checkers/trojan_source.py (Diff revision 1) Probably wanna get rid of the "2. " here
-
reviewboard/codesafety/checkers/trojan_source.py (Diff revision 1) Probably wanna get rid of the "3. " here
Change Summary:
Fixed a few documentation issues.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+384 -118) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.