Reorganize settings for the diff viewer.
Review Request #12781 — Created Jan. 11, 2023 and submitted
The diff viewer settings page is one of the oldest pages in the admin
UI, and its organization left much to be desired. Some upcoming work
will be adding to this page, and as such, it's time to clean it up.
This now groups the settings into 3 fieldsets:
Appearance contains the checkboxes for trailing whitespace and syntax
highlighting, plus the field for mapping file extensions to
Limits contains the diff size limit and the max lines for syntax
Advanced contains everything it had before, plus the "Show all
whitespace for" field, which should generally no longer be used.
Some of the field labels and help text have been tweaked to be more
clear and to provide recommendations.
Verified the page's contents on desktop and mobile.
Checked for spelling errors.
Can we also mention in here that larger diffs can cause connection errors or browser performance problems? I feel like …
reviewboard/admin/forms/diff_settings.py (Diff revision 1)
Can we also mention in here that larger diffs can cause connection errors or browser performance problems? I feel like just saying it's too big for humans isn't a good disincentive.
While this is top of mind, we really need to change the default here too.
Improved wording around the max diff size to mention the performance issues/timeouts that could occur.
Revision 2 (+110 -46)
Checks run (2 succeeded)