Reorganize settings for the diff viewer.

Review Request #12781 — Created Jan. 11, 2023 and submitted

Information

Review Board
release-5.0.x

Reviewers

The diff viewer settings page is one of the oldest pages in the admin
UI, and its organization left much to be desired. Some upcoming work
will be adding to this page, and as such, it's time to clean it up.

This now groups the settings into 3 fieldsets:

  • Appearance
  • Limits
  • Advanced

Appearance contains the checkboxes for trailing whitespace and syntax
highlighting, plus the field for mapping file extensions to
highlighters.

Limits contains the diff size limit and the max lines for syntax
highlighting.

Advanced contains everything it had before, plus the "Show all
whitespace for" field, which should generally no longer be used.

Some of the field labels and help text have been tweaked to be more
clear and to provide recommendations.

Verified the page's contents on desktop and mobile.

Checked for spelling errors.

Summary ID
Reorganize settings for the diff viewer.
The diff viewer settings page is one of the oldest pages in the admin UI, and its organization left much to be desired. Some upcoming work will be adding to this page, and as such, it's time to clean it up. This now groups the settings into 3 fieldsets: * Appearance * Limits * Advanced Appearance contains the checkboxes for trailing whitespace and syntax highlighting, plus the field for mapping file extensions to highlighters. Limits contains the diff size limit and the max lines for syntax highlighting. Advanced contains everything it had before, plus the "Show all whitespace for" field, which should generally no longer be used. Some of the field labels and help text have been tweaked to be more clear and to provide recommendations.
7658e3f0522a37c46183d9efad28d894e184cbf0

Description From Last Updated

Can we also mention in here that larger diffs can cause connection errors or browser performance problems? I feel like …

daviddavid
david
  1. 
      
  2. reviewboard/admin/forms/diff_settings.py (Diff revision 1)
     
     
     
    Show all issues

    Can we also mention in here that larger diffs can cause connection errors or browser performance problems? I feel like just saying it's too big for humans isn't a good disincentive.

    While this is top of mind, we really need to change the default here too.

    1. I'll take care of the default separately.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.0.x (b3b595b)