Summary

Sort keys in all JavaScript objects.

Review Request #12769 — Created Jan. 6, 2023 and submitted Jan. 8, 2023, 10:18 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

One of the ESLint settings we have turned on is enforcement of
alphabetical ordering within objects. Ordering is done within groups of
keys, separated by blank lines.

This change updates all our objects to be ordered. In some cases, I
opted to just add blank lines to keep certain things (like complex
functions) from having to be reordered, putting them in their own
groups.

Testing Done

Verified that ESLint was happy with ordering.

Commits

Summary	ID
Sort keys in all JavaScript objects. One of the ESLint settings we have turned on is enforcement of alphabetical ordering within objects. Ordering is done within groups of keys, separated by blank lines. This change updates all our objects to be ordered. In some cases, I opted to just add blank lines to keep certain things (like complex functions) from having to be reordered, putting them in their own groups.	bc478ebdf6d971378a9f0dba9780912a1a87146d

Summary

Sort keys in all JavaScript objects.

One of the ESLint settings we have turned on is enforcement of alphabetical ordering within objects. Ordering is done within groups of keys, separated by blank lines. This change updates all our objects to be ordered. In some cases, I opted to just add blank lines to keep certain things (like complex functions) from having to be reordered, putting them in their own groups.

bc478ebdf6d971378a9f0dba9780912a1a87146d

Issues

Description	From	Last Updated
Expected an assignment or function call and instead saw an expression. Column: 17 Error code: W030	reviewbot	Jan. 6, 2023, 2:16 a.m.
Missing semicolon. Column: 21 Error code: E058	reviewbot	Jan. 6, 2023, 2:16 a.m.
Expected an assignment or function call and instead saw an expression. Column: 23 Error code: W030	reviewbot	Jan. 6, 2023, 2:16 a.m.
Expected '}' to match '{' from line 95 and instead saw ':'. Column: 21 Error code: E020	reviewbot	Jan. 6, 2023, 2:16 a.m.
Missing semicolon. Column: 36 Error code: W033	reviewbot	Jan. 6, 2023, 2:16 a.m.

flake8 passed.

JSHint failed.

JSHint

djblets/static/djblets/js/datagrid.js (Diff revision 1)

The issue has been resolved. Show all issues

Expected an assignment or function call and instead saw an expression.

Column: 17
Error code: W030

djblets/static/djblets/js/datagrid.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing semicolon.

Column: 21
Error code: E058
```

djblets/static/djblets/js/datagrid.js (Diff revision 1)

The issue has been resolved. Show all issues

Expected an assignment or function call and instead saw an expression.

Column: 23
Error code: W030

djblets/static/djblets/js/datagrid.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Expected '}' to match '{' from line 95 and instead saw ':'.

Column: 21
Error code: E020
```
djblets/static/djblets/js/datagrid.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing semicolon.

Column: 36
Error code: W033
```

Change Summary:

Fixed a missing comma due to a bad add -p.

Commits:

	Summary	ID
	Sort keys in all JavaScript objects. One of the ESLint settings we have turned on is enforcement of alphabetical ordering within objects. Ordering is done within groups of keys, separated by blank lines. This change updates all our objects to be ordered. In some cases, I opted to just add blank lines to keep certain things (like complex functions) from having to be reordered, putting them in their own groups.	fa24c89ecca2117ce363b20422a67f911ec324b3
	Sort keys in all JavaScript objects. One of the ESLint settings we have turned on is enforcement of alphabetical ordering within objects. Ordering is done within groups of keys, separated by blank lines. This change updates all our objects to be ordered. In some cases, I opted to just add blank lines to keep certain things (like complex functions) from having to be reordered, putting them in their own groups.	bc478ebdf6d971378a9f0dba9780912a1a87146d

Diff:

Revision 2 (+318 -292)

Show changes

	djblets/static/djblets/js/datagrid.js
	djblets/static/djblets/js/jquery.gravy.autosize.js
	djblets/static/djblets/js/jquery.gravy.backboneUtils.js
	djblets/static/djblets/js/jquery.gravy.inlineEditor.js
	djblets/static/djblets/js/jquery.gravy.modalBox.js
	djblets/static/djblets/js/jquery.gravy.tooltip.js
	djblets/static/djblets/js/jquery.gravy.util.js
	djblets/static/djblets/js/admin/views/relatedObjectSelectorView.es6.js
	21 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (fabb530)