Sort keys in all JavaScript objects.

Review Request #12769 — Created Jan. 6, 2023 and submitted

Information

Djblets
release-4.x

Reviewers

One of the ESLint settings we have turned on is enforcement of
alphabetical ordering within objects. Ordering is done within groups of
keys, separated by blank lines.

This change updates all our objects to be ordered. In some cases, I
opted to just add blank lines to keep certain things (like complex
functions) from having to be reordered, putting them in their own
groups.

Verified that ESLint was happy with ordering.

Summary ID
Sort keys in all JavaScript objects.
One of the ESLint settings we have turned on is enforcement of alphabetical ordering within objects. Ordering is done within groups of keys, separated by blank lines. This change updates all our objects to be ordered. In some cases, I opted to just add blank lines to keep certain things (like complex functions) from having to be reordered, putting them in their own groups.
bc478ebdf6d971378a9f0dba9780912a1a87146d
Description From Last Updated

Expected an assignment or function call and instead saw an expression. Column: 17 Error code: W030

reviewbotreviewbot

Missing semicolon. Column: 21 Error code: E058

reviewbotreviewbot

Expected an assignment or function call and instead saw an expression. Column: 23 Error code: W030

reviewbotreviewbot

Expected '}' to match '{' from line 95 and instead saw ':'. Column: 21 Error code: E020

reviewbotreviewbot

Missing semicolon. Column: 36 Error code: W033

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (fabb530)