Summary

Convert header actions to new actions framework.

Review Request #12762 — Created Jan. 5, 2023 and submitted Feb. 27, 2023, 8:28 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates our existing header "actions" (the account menu,
support menu, and follow menu) to use the new actions framework.

Testing Done

Verified look and behavior of the header in both desktop and mobile
modes.

Commits

Summary	ID
Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	18f704adadff1850c5fe8b4db7b18784b6c0abdb

Issues

Description	From	Last Updated
Add a version added.	maubin	Jan. 12, 2023, 9:25 a.m.
These should all have Version Added.	chipx86	Jan. 30, 2023, 10:30 a.m.
This is so common that I wonder if we should have either a mixin or bake a flag into actions.	chipx86	Jan. 30, 2023, 3:25 p.m.
Similarly, maybe it's worth having either a url_name property on the base action (which get_url can use along with local_site_reverse) …	chipx86	Jan. 30, 2023, 3:25 p.m.
We're not really following via RSS, just giving a link to the news page. The naming might be best as …	chipx86	Jan. 30, 2023, 10:30 a.m.
We should still give menus and menu items an explicit class name. We've been doing that for all spec'd parts …	chipx86	Jan. 30, 2023, 2:15 p.m.
Extra blank line at the end of the file.	chipx86	Jan. 30, 2023, 10:31 a.m.
To be safe, we should always use local_site_reverse for these, with the request/Local Site being passed in. There are some …	chipx86	Feb. 3, 2023, 12:38 p.m.

flake8 passed.

JSHint passed.

reviewboard/accounts/actions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Add a version added.
```

Commits:

	Summary	ID
	Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	479dbeb79d3c102185e880de238ce16fadc3a614
	Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	8c430fbe4d8cb3143848864ca7dc387e70c33ed2

Diff:

Revision 2 (+956 -260)

Show changes

	reviewboard/accounts/actions.py
	reviewboard/actions/registry.py
	reviewboard/static/rb/css/mixins/theme.less
	reviewboard/static/rb/css/pages/base.less
	reviewboard/templates/accounts/account_menu_action.html
	reviewboard/templates/base/_nav_support_menu.html
	reviewboard/templates/base/headerbar.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/accounts/actions.py (Diff revision 2)
The issue has been resolved. Show all issues
```
These should all have Version Added.
```

reviewboard/accounts/actions.py (Diff revision 2)

The issue has been resolved. Show all issues

This is so common that I wonder if we should have either a mixin or bake a flag into actions.

reviewboard/accounts/actions.py (Diff revision 2)

The issue has been resolved. Show all issues

Similarly, maybe it's worth having either a url_name property on the base action (which get_url can use along with local_site_reverse) or a mixin, so actions are consistent in behavior by default?

reviewboard/accounts/actions.py (Diff revision 2)

The issue has been resolved. Show all issues

We're not really following via RSS, just giving a link to the news page. The naming might be best as just FollowNewsAction or something.

reviewboard/static/rb/css/pages/base.less (Diff revision 2)

The issue has been resolved. Show all issues

We should still give menus and menu items an explicit class name. We've been doing that for all spec'd parts of a component.

reviewboard/templates/accounts/account_menu_action.html (Diff revision 2)
The issue has been resolved. Show all issues
```
Extra blank line at the end of the file.
```

Commits:

	Summary	ID
	Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	8c430fbe4d8cb3143848864ca7dc387e70c33ed2
	Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	9226be952866f61028c6d981cd5ec29e97e9755f

Diff:

Revision 3 (+946 -260)

Show changes

	reviewboard/accounts/actions.py
	reviewboard/actions/base.py
	reviewboard/actions/registry.py
	reviewboard/static/rb/css/mixins/theme.less
	reviewboard/static/rb/css/pages/base.less
	reviewboard/templates/accounts/account_menu_action.html
	reviewboard/templates/base/_nav_support_menu.html
	reviewboard/templates/base/headerbar.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/actions/base.py (Diff revision 3)

The issue has been resolved. Show all issues

To be safe, we should always use local_site_reverse for these, with the request/Local Site being passed in. There are some normally top-level URLs on RBCommons that require a Local Site.

Change Summary:

Switch to local_site_reverse

Commits:

	Summary	ID
	Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	9226be952866f61028c6d981cd5ec29e97e9755f
	Convert header actions to new actions framework. This change updates our existing header "actions" (the account menu, support menu, and follow menu) to use the new actions framework. Testing Done: Verified look and behavior of the header in both desktop and mobile modes.	18f704adadff1850c5fe8b4db7b18784b6c0abdb

Diff:

Revision 4 (+950 -260)

Show changes

	reviewboard/accounts/actions.py
	reviewboard/actions/base.py
	reviewboard/actions/registry.py
	reviewboard/static/rb/css/mixins/theme.less
	reviewboard/static/rb/css/pages/base.less
	reviewboard/templates/accounts/account_menu_action.html
	reviewboard/templates/base/_nav_support_menu.html
	reviewboard/templates/base/headerbar.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (d77fc91)