flake8
passed.
JSHint
passed.
Convert header actions to new actions framework.
Review Request #12762 — Created Jan. 5, 2023 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
This change updates our existing header "actions" (the account menu,
support menu, and follow menu) to use the new actions framework.
Verified look and behavior of the header in both desktop and mobile
modes.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Add a version added. |
 maubin
|
|
|
These should all have Version Added. |
 chipx86
|
|
|
This is so common that I wonder if we should have either a mixin or bake a flag into actions. |
chipx86
|
|
|
Similarly, maybe it's worth having either a url_name property on the base action (which get_url can use along with local_site_reverse) … |
chipx86
|
|
|
We're not really following via RSS, just giving a link to the news page. The naming might be best as … |
chipx86
|
|
|
We should still give menus and menu items an explicit class name. We've been doing that for all spec'd parts … |
chipx86
|
|
|
Extra blank line at the end of the file. |
chipx86
|
|
|
To be safe, we should always use local_site_reverse for these, with the request/Local Site being passed in. There are some … |
chipx86
|
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+956 -260) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
-
reviewboard/accounts/actions.py (Diff revision 2) This is so common that I wonder if we should have either a mixin or bake a flag into actions.
-
reviewboard/accounts/actions.py (Diff revision 2) Similarly, maybe it's worth having either a
url_nameproperty on the base action (whichget_urlcan use along withlocal_site_reverse) or a mixin, so actions are consistent in behavior by default? -
reviewboard/accounts/actions.py (Diff revision 2) We're not really following via RSS, just giving a link to the news page. The naming might be best as just
FollowNewsActionor something. -
reviewboard/static/rb/css/pages/base.less (Diff revision 2) We should still give menus and menu items an explicit class name. We've been doing that for all spec'd parts of a component.
-
reviewboard/templates/accounts/account_menu_action.html (Diff revision 2) Extra blank line at the end of the file.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+946 -260) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
reviewboard/actions/base.py (Diff revision 3) To be safe, we should always use
local_site_reversefor these, with the request/Local Site being passed in. There are some normally top-level URLs on RBCommons that require a Local Site.
Change Summary:
Switch to local_site_reverse
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+950 -260) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.