Summary

Add draft release notes for Review Board 5.0.2

Review Request #12755 — Created Dec. 9, 2022 and submitted Feb. 6, 2023, 9:07 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change adds the release notes for the upcoming 5.0.2 release. This
provides a mix of new features and bug fixes.

Some notable new features include Trojan Source detection settings, API
token time-based expiration, enabling ACL support for diffs for
extensions, and reworked URI templates.

There are also fixes in the diff viewer, crashes fixes for upgrades, and
mimetype fixes for JSON and YAML files.

Testing Done

Built HTML and checked the output.

Commits

Summary	ID
Add draft release notes for Review Board 5.0.2 This change adds the release notes for the upcoming 5.0.2 release. This provides a mix of new features and bug fixes. Some notable new features include Trojan Source detection settings, API token time-based expiration, enabling ACL support for diffs for extensions, and reworked URI templates. There are also fixes in the diff viewer, crashes fixes for upgrades, and mimetype fixes for JSON and YAML files.	a2249948a29d223fe6528f8a0e0274789dc1eeeb

Summary

Add draft release notes for Review Board 5.0.2

This change adds the release notes for the upcoming 5.0.2 release. This provides a mix of new features and bug fixes. Some notable new features include Trojan Source detection settings, API token time-based expiration, enabling ACL support for diffs for extensions, and reworked URI templates. There are also fixes in the diff viewer, crashes fixes for upgrades, and mimetype fixes for JSON and YAML files.

a2249948a29d223fe6528f8a0e0274789dc1eeeb

Issues

Description	From	Last Updated
I haven't landed the URI templates change yet, but this is an important one that will require some explanation and …	chipx86	Feb. 3, 2023, 5:58 p.m.
We'll need to document the Djblets version bump as part of this in Packaging (that release will also require some …	chipx86	Feb. 3, 2023, 5:58 p.m.
This one was already added in 5.0.1.	maubin	Dec. 12, 2022, 9:17 a.m.
This should use console, to get the newer styling.	chipx86	Dec. 14, 2022, 9:16 a.m.
This can use :guilabel: for the label text.	chipx86	Dec. 14, 2022, 9:16 a.m.
The text doesn't really tell the users how it impacted them. Let's add on "..., showing the wrong text and …	chipx86	Dec. 14, 2022, 9:16 a.m.
I feel like "bug views" (and "infobox and redirect" (without further clarification)) assumes some knowledge readers likely won't have. Let's …	chipx86	Dec. 14, 2022, 9:17 a.m.
We can probably clarify this just a tad. Instead of "text-type reviewables," we can say "were not able to be …	chipx86	Dec. 14, 2022, 9:18 a.m.
Extra blank line here.	chipx86	Dec. 14, 2022, 9:18 a.m.

flake8 passed.

JSHint passed.

I do have this change from a while ago that I never landed, it's for improving the token expiration controls from the API tokens config page. I think it's ready to go, should we try to get it in for 5.0.2 or save it for a different release?

david Dec. 12, 2022, 9:18 a.m.

Given the size of that I think sneaking it in just prior to release is maybe not wise. Let's get it landed right after we ship and test it a bit.

docs/releasenotes/5.0.2.rst (Diff revision 1)

The issue has been resolved. Show all issues

This one was already added in 5.0.1.

david Dec. 9, 2022, 2:40 p.m.

It looks like not. It had been pushed to release-4.0.x but that wasn't merged to release-5.0.x until after the 5.0.1 release.

maubin Dec. 9, 2022, 2:48 p.m.

Ah yeah it looks like that because I had made a separate commit and review request for fixing the bug in 4.0.x and 5.0.x. This is the commit that contained the bug fix for 5.0.x. It was actually added in 5.0, not 5.0.1.

david Dec. 12, 2022, 9:17 a.m.
```
Ah, I see.
```

Commits:

	Summary	ID	Author
	Add draft release notes for Review Board 5.0.2. This change adds the release notes for the upcoming 5.0.2 bugfix release. Testing Done: Built HTML and checked the output.	7f7a6c674ef48b4615c4a9ace72e26b2c1d2281c	David Trowbridge
	Add draft release notes for Review Board 5.0.2. This change adds the release notes for the upcoming 5.0.2 bugfix release. Testing Done: Built HTML and checked the output.	acf3730c04d7f4cdaa4e1636717b8ce844ea15d3	David Trowbridge

Diff:

Revision 2 (+102)

Show changes

	docs/releasenotes/5.0.2.rst
	docs/releasenotes/index.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

docs/releasenotes/5.0.2.rst (Diff revision 2)
The issue has been resolved. Show all issues
```
This should use console, to get the newer styling.
```
docs/releasenotes/5.0.2.rst (Diff revision 2)
The issue has been resolved. Show all issues
```
This can use :guilabel: for the label text.
```

docs/releasenotes/5.0.2.rst (Diff revision 2)

The issue has been resolved. Show all issues

The text doesn't really tell the users how it impacted them. Let's add on "..., showing the wrong text and making it hard to determine if clicking the button would show or hide extra whitespace."

docs/releasenotes/5.0.2.rst (Diff revision 2)

The issue has been resolved. Show all issues

I feel like "bug views" (and "infobox and redirect" (without further clarification)) assumes some knowledge readers likely won't have.

Let's maybe refer to these as "internal URLs used to serve up information on bug/ticket IDs".

docs/releasenotes/5.0.2.rst (Diff revision 2)

The issue has been resolved. Show all issues

We can probably clarify this just a tad. Instead of "text-type reviewables," we can say "were not able to be reviewed as normal text files, instead only allowing users to download them or leave a comment on the file as a whole."

docs/releasenotes/5.0.2.rst (Diff revision 2)
The issue has been resolved. Show all issues
```
Extra blank line here.
```

The issue has been resolved. Show all issues

I haven't landed the URI templates change yet, but this is an important one that will require some explanation and pointing to the root resource page for details.

david Dec. 14, 2022, 9:46 a.m.

If there's any content in particular you'd like for that, please let me know.

The issue has been resolved. Show all issues

We'll need to document the Djblets version bump as part of this in Packaging (that release will also require some release notes).

david Dec. 14, 2022, 9:46 a.m.

Are we calling that 3.2? Did you want me to write relnotes for that too?

Rel notes for the token expiration change (feel free to change as you wish):
The settings for API Token expirations in the My Account page have been improved. In addition to setting the date, you can now set the specific expiration time of tokens. It is also possible to edit the expiration of already expired tokens, and to set the expiration to a past date and time.

Change Summary:

Taking on the rest of the release notes.

Owner:

-	david
+	chipx86

Change Summary:

Added the remaining changes for 5.0.2.

Summary:

-	Add draft release notes for Review Board 5.0.2.
+	Add draft release notes for Review Board 5.0.2

Description:

~		This change adds the release notes for the upcoming 5.0.2 bugfix release.
	~	This change adds the release notes for the upcoming 5.0.2 release. This
	+	provides a mix of new features and bug fixes.
	+
	+	Some notable new features include Trojan Source detection settings, API
	+	token time-based expiration, enabling ACL support for diffs for
	+	extensions, and reworked URI templates.
	+
	+	There are also fixes in the diff viewer, crashes fixes for upgrades, and
	+	mimetype fixes for JSON and YAML files.

Commits:

	Summary	ID	Author
	Add draft release notes for Review Board 5.0.2. This change adds the release notes for the upcoming 5.0.2 bugfix release. Testing Done: Built HTML and checked the output.	acf3730c04d7f4cdaa4e1636717b8ce844ea15d3	David Trowbridge
	Add draft release notes for Review Board 5.0.2 This change adds the release notes for the upcoming 5.0.2 release. This provides a mix of new features and bug fixes. Some notable new features include Trojan Source detection settings, API token time-based expiration, enabling ACL support for diffs for extensions, and reworked URI templates. There are also fixes in the diff viewer, crashes fixes for upgrades, and mimetype fixes for JSON and YAML files.	49f044b9f735416df79e2f5690e7888aec8ad817	Christian Hammond

Diff:

Revision 3 (+298)

Show changes

	docs/releasenotes/5.0.2.rst
	docs/releasenotes/index.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Added the new fix for a crash during diff upload for some parent diffs.

Commits:

	Summary	ID
	Add draft release notes for Review Board 5.0.2 This change adds the release notes for the upcoming 5.0.2 release. This provides a mix of new features and bug fixes. Some notable new features include Trojan Source detection settings, API token time-based expiration, enabling ACL support for diffs for extensions, and reworked URI templates. There are also fixes in the diff viewer, crashes fixes for upgrades, and mimetype fixes for JSON and YAML files.	49f044b9f735416df79e2f5690e7888aec8ad817
	Add draft release notes for Review Board 5.0.2 This change adds the release notes for the upcoming 5.0.2 release. This provides a mix of new features and bug fixes. Some notable new features include Trojan Source detection settings, API token time-based expiration, enabling ACL support for diffs for extensions, and reworked URI templates. There are also fixes in the diff viewer, crashes fixes for upgrades, and mimetype fixes for JSON and YAML files.	a2249948a29d223fe6528f8a0e0274789dc1eeeb

Diff:

Revision 4 (+310)

Show changes

	docs/releasenotes/5.0.2.rst
	docs/releasenotes/index.rst

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (5bfc0c4)