Summary

Add bulletproofing to the bug views.

Review Request #12751 — Created Dec. 7, 2022 and submitted Dec. 21, 2022, 9:49 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We're hitting some crashes on the demo server from bots accessing the

bug redirect view for a review request that does not have an associated

repository. This view made an assumption that the repository exists,

which is generally fine for normal usage but fails when crawlers try to

be clever.
This change adds some bulletproofing to the bug-related views to

validate that the repository exists and return a 404 if it doesn't.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add bulletproofing to the bug views. We're hitting some crashes on the demo server from bots accessing the bug redirect view for a review request that does not have an associated repository. This view made an assumption that the repository exists, which is generally fine for normal usage but fails when crawlers try to be clever. This change adds some bulletproofing to the bug-related views to validate that the repository exists and return a 404 if it doesn't. Testing Done: Ran unit tests.	cc7ef5c0c7a39caa416903b79b4f6ab33b3b2f92

Summary

Add bulletproofing to the bug views.

We're hitting some crashes on the demo server from bots accessing the bug redirect view for a review request that does not have an associated repository. This view made an assumption that the repository exists, which is generally fine for normal usage but fails when crawlers try to be clever. This change adds some bulletproofing to the bug-related views to validate that the repository exists and return a 404 if it doesn't. Testing Done: Ran unit tests.

cc7ef5c0c7a39caa416903b79b4f6ab33b3b2f92

Issues

Description	From	Last Updated
Looks fine, but can you add unit tests so we have coverage here?	chipx86	Dec. 7, 2022, 3:06 p.m.
Typo in the filename: infoxbox -> infobox. To be consistent, though, let's use infobox_view in the name.	chipx86	Dec. 14, 2022, 9:13 a.m.
Would be more accurate as BugInfoboxViewTests.	chipx86	Dec. 14, 2022, 9:15 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Looks fine, but can you add unit tests so we have coverage here?

Change Summary:

Add unit tests to validate new behavior.

Commits:

	Summary	ID
	Add bulletproofing to the bug views. We're hitting some crashes on the demo server from bots accessing the bug redirect view for a review request that does not have an associated repository. This view made an assumption that the repository exists, which is generally fine for normal usage but fails when crawlers try to be clever. This change adds some bulletproofing to the bug-related views to validate that the repository exists and return a 404 if it doesn't. Testing Done: Ran unit tests.	48448ebfd4f0aa6da2818ef2d2d65bc10d95e261
	Add bulletproofing to the bug views. We're hitting some crashes on the demo server from bots accessing the bug redirect view for a review request that does not have an associated repository. This view made an assumption that the repository exists, which is generally fine for normal usage but fails when crawlers try to be clever. This change adds some bulletproofing to the bug-related views to validate that the repository exists and return a 404 if it doesn't. Testing Done: Ran unit tests.	765d4880c58dc4280528ca6ffdf97fcc8e4148d4

Diff:

Revision 2 (+88 -4)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_bug_infoxbox.py
	reviewboard/reviews/tests/test_bug_url_redirect_view.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Typo in the filename: infoxbox -> infobox.

To be consistent, though, let's use infobox_view in the name.

david Dec. 14, 2022, 9:15 a.m.
```
Perhaps we should introduce foxboxes.
```

reviewboard/reviews/tests/test_bug_infoxbox.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Would be more accurate as BugInfoboxViewTests.
```

Commits:

	Summary	ID
	Add bulletproofing to the bug views. We're hitting some crashes on the demo server from bots accessing the bug redirect view for a review request that does not have an associated repository. This view made an assumption that the repository exists, which is generally fine for normal usage but fails when crawlers try to be clever. This change adds some bulletproofing to the bug-related views to validate that the repository exists and return a 404 if it doesn't. Testing Done: Ran unit tests.	765d4880c58dc4280528ca6ffdf97fcc8e4148d4
	Add bulletproofing to the bug views. We're hitting some crashes on the demo server from bots accessing the bug redirect view for a review request that does not have an associated repository. This view made an assumption that the repository exists, which is generally fine for normal usage but fails when crawlers try to be clever. This change adds some bulletproofing to the bug-related views to validate that the repository exists and return a 404 if it doesn't. Testing Done: Ran unit tests.	cc7ef5c0c7a39caa416903b79b4f6ab33b3b2f92

Diff:

Revision 3 (+88 -4)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/tests/test_bug_infobox_view.py
	reviewboard/reviews/tests/test_bug_url_redirect_view.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (cfcd0dc)