Summary

Update to Backbone.js 1.4.1.

Review Request #12748 — Created Dec. 1, 2022 and submitted Dec. 7, 2022, 3:37 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This updates us to the latest Backbone release.

Testing Done


Ran js-tests.
Played around with the UI a bit and saw everything working as

  expected.

Commits

Summary	ID
Update to Backbone.js 1.4.1. This updates us to the latest Backbone release. Testing Done: - Ran js-tests. - Played around with the UI a bit and saw everything working as expected.	ba28184f310c63a41dc9e1395f075d16efac2cb0

Issues

Description	From	Last Updated
Expected '===' and instead saw '=='. Column: 28 Error code: W116	reviewbot	Dec. 1, 2022, 11:15 a.m.
Expected '===' and instead saw '=='. Column: 29 Error code: W116	reviewbot	Dec. 1, 2022, 11:15 a.m.
You might be leaking a variable (_listening) here. Column: 21 Error code: W120	reviewbot	Dec. 1, 2022, 11:15 a.m.
Expected an assignment or function call and instead saw an expression. Column: 58 Error code: W030	reviewbot	Dec. 1, 2022, 11:15 a.m.
Expected '{' and instead saw 'throw'. Column: 16 Error code: W116	reviewbot	Dec. 1, 2022, 11:15 a.m.
Expected '{' and instead saw 'listening'. Column: 28 Error code: W116	reviewbot	Dec. 1, 2022, 11:15 a.m.
'tryCatchOn' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'listening'. Column: 30 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'this'. Column: 33 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'listening'. Column: 26 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
'Listening' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'this'. Column: 18 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'delete'. Column: 24 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'comparator'. Column: 37 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
'CollectionIterator' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
'ITERATOR_VALUES' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
'ITERATOR_KEYS' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
'ITERATOR_KEYSVALUES' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'Class'. Column: 25 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
'cb' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'return'. Column: 33 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'return'. Column: 63 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'return'. Column: 31 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
'modelMatcher' was used before it was defined. Column: 7 Error code: W003	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '{' and instead saw 'return'. Column: 46 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '===' and instead saw '=='. Column: 82 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Expected '===' and instead saw '=='. Column: 33 Error code: W116	reviewbot	Dec. 1, 2022, 11:16 a.m.
Missing semicolon. Column: 244 Error code: W033	reviewbot	Dec. 1, 2022, 11:16 a.m.
Missing semicolon. Column: 246 Error code: W033	reviewbot	Dec. 1, 2022, 11:16 a.m.
Missing semicolon. Column: 338 Error code: W033	reviewbot	Dec. 1, 2022, 11:16 a.m.

flake8 passed.

JSHint failed.

JSHint

```
Warning: Showing 30 of 467 failures.
```
reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
Expected '===' and instead saw '=='.

Column: 28
Error code: W116
```
reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
Expected '===' and instead saw '=='.

Column: 29
Error code: W116
```

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

You might be leaking a variable (_listening) here.

Column: 21
Error code: W120

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected an assignment or function call and instead saw an expression.

Column: 58
Error code: W030

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
Expected '{' and instead saw 'throw'.

Column: 16
Error code: W116
```

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'listening'.

Column: 28
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'tryCatchOn' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'listening'.

Column: 30
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
Expected '{' and instead saw 'this'.

Column: 33
Error code: W116
```

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'listening'.

Column: 26
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'Listening' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
Expected '{' and instead saw 'this'.

Column: 18
Error code: W116
```

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'delete'.

Column: 24
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'comparator'.

Column: 37
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'CollectionIterator' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'ITERATOR_VALUES' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'ITERATOR_KEYS' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'ITERATOR_KEYSVALUES' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
Expected '{' and instead saw 'Class'.

Column: 25
Error code: W116
```
reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)
Show all issues
```
'cb' was used before it was defined.

Column: 7
Error code: W003
```

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'return'.

Column: 33
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'return'.

Column: 63
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'return'.

Column: 31
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

'modelMatcher' was used before it was defined.

Column: 7
Error code: W003

reviewboard/static/lib/js/backbone-1.4.1.js (Diff revision 1)

Show all issues

Expected '{' and instead saw 'return'.

Column: 46
Error code: W116

reviewboard/static/lib/js/backbone-1.4.1.min.js (Diff revision 1)
Show all issues
```
Expected '===' and instead saw '=='.

Column: 82
Error code: W116
```
reviewboard/static/lib/js/backbone-1.4.1.min.js (Diff revision 1)
Show all issues
```
Expected '===' and instead saw '=='.

Column: 33
Error code: W116
```
reviewboard/static/lib/js/backbone-1.4.1.min.js (Diff revision 1)
Show all issues
```
Missing semicolon.

Column: 244
Error code: W033
```
reviewboard/static/lib/js/backbone-1.4.1.min.js (Diff revision 1)
Show all issues
```
Missing semicolon.

Column: 246
Error code: W033
```
reviewboard/static/lib/js/backbone-1.4.1.min.js (Diff revision 1)
Show all issues
```
Missing semicolon.

Column: 338
Error code: W033
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (85a1dda)