Update to Backbone.js 1.4.1.

Review Request #12748 — Created Dec. 1, 2022 and submitted

Information

Review Board
release-6.x

Reviewers

This updates us to the latest Backbone release.

  • Ran js-tests.
  • Played around with the UI a bit and saw everything working as
    expected.
Summary ID
Update to Backbone.js 1.4.1.
This updates us to the latest Backbone release. Testing Done: - Ran js-tests. - Played around with the UI a bit and saw everything working as expected.
ba28184f310c63a41dc9e1395f075d16efac2cb0
Description From Last Updated

Expected '===' and instead saw '=='. Column: 28 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 29 Error code: W116

reviewbotreviewbot

You might be leaking a variable (_listening) here. Column: 21 Error code: W120

reviewbotreviewbot

Expected an assignment or function call and instead saw an expression. Column: 58 Error code: W030

reviewbotreviewbot

Expected '{' and instead saw 'throw'. Column: 16 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'listening'. Column: 28 Error code: W116

reviewbotreviewbot

'tryCatchOn' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

Expected '{' and instead saw 'listening'. Column: 30 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'this'. Column: 33 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'listening'. Column: 26 Error code: W116

reviewbotreviewbot

'Listening' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

Expected '{' and instead saw 'this'. Column: 18 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'delete'. Column: 24 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'comparator'. Column: 37 Error code: W116

reviewbotreviewbot

'CollectionIterator' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

'ITERATOR_VALUES' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

'ITERATOR_KEYS' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

'ITERATOR_KEYSVALUES' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

Expected '{' and instead saw 'Class'. Column: 25 Error code: W116

reviewbotreviewbot

'cb' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

Expected '{' and instead saw 'return'. Column: 33 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'return'. Column: 63 Error code: W116

reviewbotreviewbot

Expected '{' and instead saw 'return'. Column: 31 Error code: W116

reviewbotreviewbot

'modelMatcher' was used before it was defined. Column: 7 Error code: W003

reviewbotreviewbot

Expected '{' and instead saw 'return'. Column: 46 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 82 Error code: W116

reviewbotreviewbot

Expected '===' and instead saw '=='. Column: 33 Error code: W116

reviewbotreviewbot

Missing semicolon. Column: 244 Error code: W033

reviewbotreviewbot

Missing semicolon. Column: 246 Error code: W033

reviewbotreviewbot

Missing semicolon. Column: 338 Error code: W033

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-6.x (85a1dda)