Add an app_name argument to build_integration_urlpatterns().

Review Request #12745 — Created Nov. 28, 2022 and submitted

Information

Djblets
release-3.x

Reviewers

Django 3.x and higher require specifying an app name when also
specifying a namespace for include() when building URL patterns.
This change adds app_name to complement namespace in
build_integration_urlpatterns().

The function itself now expects keyword arguments. Positional arguments
are supported but deprecated with a warning.

Type hints have also been added throughout djblets.integrations.urls.

Made use of this with RBCommons, which needs this on Django 3.2.

Summary ID
Add an app_name argument to build_integration_urlpatterns().
Django 3.x and higher require specifying an app name when also specifying a namespace for `include()` when building URL patterns. This change adds `app_name` to complement `namespace` in `build_integration_urlpatterns()`. The function itself now expects keyword arguments. Positional arguments are supported but deprecated with a warning. Type hints have also been added throughout `djblets.integrations.urls`.
894e37750476ef4ca535509752959f7cebbb1b37
Description From Last Updated

'django.urls.URLResolver' imported but unused Column: 1 Error code: F401

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.x (2046b85)