Summary

Add an app_name argument to build_integration_urlpatterns().

Review Request #12745 — Created Nov. 28, 2022 and submitted Jan. 8, 2023, 10:19 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Django 3.x and higher require specifying an app name when also

specifying a namespace for include() when building URL patterns.

This change adds app_name to complement namespace in

build_integration_urlpatterns().
The function itself now expects keyword arguments. Positional arguments

are supported but deprecated with a warning.
Type hints have also been added throughout djblets.integrations.urls.

Testing Done

Made use of this with RBCommons, which needs this on Django 3.2.

Commits

Summary	ID
Add an app_name argument to build_integration_urlpatterns(). Django 3.x and higher require specifying an app name when also specifying a namespace for `include()` when building URL patterns. This change adds `app_name` to complement `namespace` in `build_integration_urlpatterns()`. The function itself now expects keyword arguments. Positional arguments are supported but deprecated with a warning. Type hints have also been added throughout `djblets.integrations.urls`.	894e37750476ef4ca535509752959f7cebbb1b37

Summary

Add an app_name argument to build_integration_urlpatterns().

Django 3.x and higher require specifying an app name when also specifying a namespace for `include()` when building URL patterns. This change adds `app_name` to complement `namespace` in `build_integration_urlpatterns()`. The function itself now expects keyword arguments. Positional arguments are supported but deprecated with a warning. Type hints have also been added throughout `djblets.integrations.urls`.

894e37750476ef4ca535509752959f7cebbb1b37

Issues

Description	From	Last Updated
'django.urls.URLResolver' imported but unused Column: 1 Error code: F401	reviewbot	Nov. 28, 2022, 6:17 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/integrations/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'django.urls.URLResolver' imported but unused

Column: 1
Error code: F401
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add an app_name argument to build_integration_urlpatterns(). Django 3.x and higher require specifying an app name when also specifying a namespace for `include()` when building URL patterns. This change adds `app_name` to complement `namespace` in `build_integration_urlpatterns()`. The function itself now expects keyword arguments. Positional arguments are supported but deprecated with a warning. Type hints have also been added throughout `djblets.integrations.urls`.	5a1aa5337bc59ebdf8de0c3b17746b9eab0b3827
	Add an app_name argument to build_integration_urlpatterns(). Django 3.x and higher require specifying an app name when also specifying a namespace for `include()` when building URL patterns. This change adds `app_name` to complement `namespace` in `build_integration_urlpatterns()`. The function itself now expects keyword arguments. Positional arguments are supported but deprecated with a warning. Type hints have also been added throughout `djblets.integrations.urls`.	894e37750476ef4ca535509752959f7cebbb1b37

Diff:

Revision 2 (+102 -10)

Show changes

djblets/integrations/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (2046b85)