Summary:

Switch all cases of window.location over to RB.navigateTo.

Review Request #12736 — Created Nov. 22, 2022 and submitted Dec. 7, 2022, 3:38 p.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

The new navigateTo method allows us to spy on things that would cause
the page to reload or navigate away during the test suite. We have a
couple cases of similar methods that were just part of other objects,
and a bunch of cases where we were assigning directly to
window.location. This change switches everything over to the new one.

Testing Done

Ran js-tests.

Commits

Summary
	Switch all cases of window.location over to RB.navigateTo.

Screenshots

Issues

Description	From	Last Updated
Worth noting for here and other replace() usage: replace() will replace the history entry, whereas navigateTo() will append a history …	chipx86	Dec. 1, 2022, 11:52 a.m.
boolean in JavaScript.	chipx86	Dec. 7, 2022, 3:38 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/views/dummyReviewableView.es6.js (Diff revision 1)

Show all issues

Worth noting for here and other replace() usage: replace() will replace the history entry, whereas navigateTo() will append a history entry. Matters for the Back button, and what we want for switching tabs/views in the review UIs.

I'd suggest we augment navigateTo() to take options and pass in a replace: true for these.

Change Summary:

Add a replace option.

Commits:

	Summary
-		Switch all cases of window.location over to RB.navigateTo.
+		Switch all cases of window.location over to RB.navigateTo.

Diff:

Revision 2 (+64 -100)

Show changes

	reviewboard/static/rb/js/models/uploadDiffModel.es6.js
	reviewboard/static/rb/js/newReviewRequest/views/commitView.es6.js
	reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.es6.js
	reviewboard/static/rb/js/newReviewRequest/views/postCommitView.es6.js
	reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.es6.js
	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js
	reviewboard/static/rb/js/utils/urlUtils.es6.js
	6 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Awesome, thank you for doing this!
```
reviewboard/static/rb/js/utils/urlUtils.es6.js (Diff revision 2)
Show all issues
```
boolean in JavaScript.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (7c5010b)