Summary

Allow the use of typescript (.ts) files.

Review Request #12727 — Created Nov. 17, 2022 and submitted Nov. 22, 2022, 3:15 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change adds the babel preset for typescript and a babel compiler
that matches it. With this, .ts files can be added to JavaScript
bundles and will work correctly.

I've stuck a tsconfig.json file in the root. This isn't critical because
we don't use tsc to compile .ts to .js (that job is handled by babel),
but this allows us to use things like tsserver for the dev environment
without getting errors about non-ES3 constructs.

Testing Done

Used some .ts files in the Review Board codebase.

Commits

Summary	ID
Allow the use of typescript (.ts) files. This change adds the babel preset for typescript and a babel compiler that matches it. With this, `.ts` files can be added to JavaScript bundles and will work correctly. I've stuck a tsconfig.json file in the root. This isn't critical because we don't use tsc to compile .ts to .js (that job is handled by babel), but this allows us to use things like tsserver for the dev environment without getting errors about non-ES3 constructs. Testing Done: Used some `.ts` files in the Review Board codebase.	4f55e268384210ee40a4d38d33359b423f53577d

Summary

Allow the use of typescript (.ts) files.

This change adds the babel preset for typescript and a babel compiler that matches it. With this, `.ts` files can be added to JavaScript bundles and will work correctly. I've stuck a tsconfig.json file in the root. This isn't critical because we don't use tsc to compile .ts to .js (that job is handled by babel), but this allows us to use things like tsserver for the dev environment without getting errors about non-ES3 constructs. Testing Done: Used some `.ts` files in the Review Board codebase.

4f55e268384210ee40a4d38d33359b423f53577d

Issues

Description	From	Last Updated
Can you add a Version Added here and to the class?	chipx86	Nov. 22, 2022, 8:12 a.m.

flake8 passed.

JSHint passed.

djblets/pipeline/compilers/typescript.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a Version Added here and to the class?
```

Commits:

	Summary	ID
	Allow the use of typescript (.ts) files. This change adds the babel preset for typescript and a babel compiler that matches it. With this, `.ts` files can be added to JavaScript bundles and will work correctly. I've stuck a tsconfig.json file in the root. This isn't critical because we don't use tsc to compile .ts to .js (that job is handled by babel), but this allows us to use things like tsserver for the dev environment without getting errors about non-ES3 constructs. Testing Done: Used some `.ts` files in the Review Board codebase.	d5049497ec91fba66c5d9259fccbf7f068cdcea5
	Allow the use of typescript (.ts) files. This change adds the babel preset for typescript and a babel compiler that matches it. With this, `.ts` files can be added to JavaScript bundles and will work correctly. I've stuck a tsconfig.json file in the root. This isn't critical because we don't use tsc to compile .ts to .js (that job is handled by babel), but this allows us to use things like tsserver for the dev environment without getting errors about non-ES3 constructs. Testing Done: Used some `.ts` files in the Review Board codebase.	4f55e268384210ee40a4d38d33359b423f53577d

Diff:

Revision 2 (+98 -2)

Show changes

	tsconfig.json
	djblets/dependencies.py
	djblets/pipeline/settings.py
	djblets/pipeline/compilers/typescript.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (1dcacc8)