Summary

Add type hints and update documentation for notifications.email.

Review Request #12713 — Created Nov. 4, 2022 and submitted Nov. 18, 2022, 4:12 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change adds type hints for the reviewboard.notifications.email
module, and updates/fixes documentation where appropriate.

Testing Done

Ran unit tests.

Commits

Summary	ID
Add type hints and update documentation for notifications.email. This change adds type hints for the reviewboard.notifications.email module, and updates/fixes documentation where appropriate. Testing Done: Ran unit tests.	35cc38def28a65960b570749d402982b897f9b4a

Issues

Description	From	Last Updated
Add -> None	maubin	Nov. 15, 2022, 2:48 p.m.
RecipientList should come before build_recipients and recipients_to_addresses (capitals before lowercase).	maubin	Nov. 18, 2022, 4:10 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Fix a typo I found in a docstring.

Commits:

	Summary	ID
	Add type hints and update documentation for notifications.email. This change adds type hints for the reviewboard.notifications.email module, and updates/fixes documentation where appropriate. Testing Done: Ran unit tests.	ada866d4c3159087a078c89c3bd7e9369ef50d27
	Add type hints and update documentation for notifications.email. This change adds type hints for the reviewboard.notifications.email module, and updates/fixes documentation where appropriate. Testing Done: Ran unit tests.	30e74ddf3ed144d02f2a866366b63c389a571070

Diff:

Revision 2 (+516 -194)

Show changes

	reviewboard/notifications/email/__init__.py
	reviewboard/notifications/email/backend.py
	reviewboard/notifications/email/decorators.py
	reviewboard/notifications/email/hooks.py
	reviewboard/notifications/email/message.py
	reviewboard/notifications/email/signal_handlers.py
	reviewboard/notifications/email/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/notifications/email/message.py (Diff revision 2)
Show all issues
```
Add -> None
```

Commits:

	Summary	ID
	Add type hints and update documentation for notifications.email. This change adds type hints for the reviewboard.notifications.email module, and updates/fixes documentation where appropriate. Testing Done: Ran unit tests.	30e74ddf3ed144d02f2a866366b63c389a571070
	Add type hints and update documentation for notifications.email. This change adds type hints for the reviewboard.notifications.email module, and updates/fixes documentation where appropriate. Testing Done: Ran unit tests.	35cc38def28a65960b570749d402982b897f9b4a

Diff:

Revision 3 (+518 -196)

Show changes

	reviewboard/notifications/email/__init__.py
	reviewboard/notifications/email/backend.py
	reviewboard/notifications/email/decorators.py
	reviewboard/notifications/email/hooks.py
	reviewboard/notifications/email/message.py
	reviewboard/notifications/email/signal_handlers.py
	reviewboard/notifications/email/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/notifications/email/message.py (Diff revision 3)

Show all issues

RecipientList should come before build_recipients and recipients_to_addresses (capitals before lowercase).

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (81e961f)