• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Split up e-mail templates into containers and content.
    
 
    

    



 
    
 
    

  Review Request #12712
  —
  Created Nov. 3, 2022 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-6.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    In preparation for introducing batched e-mails, this splits up each of
    
our e-mail templates into containers (which just have headers like the
    
auto-generated email blob and footers like signatures) and content.
    
There's a tiny bit of clean-up done but no actual changes have been made
    
to the content of the emails themselves.
    
 
    

    





  

    
 
 
    
  
    Looked at email preview views for review requests, reviews, and review
    
replies in both html and text formats. Saw everything work as expected.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Split up e-mail templates into containers and content.
      
    In preparation for introducing batched e-mails, this splits up each of
our e-mail templates into containers (which just have headers like the
auto-generated email blob and footers like signatures) and content.
There's a tiny bit of clean-up done but no actual changes have been made
to the content of the emails themselves.

Testing Done:
Looked at email preview views for review requests, reviews, and review
replies in both html and text formats. Saw everything work as expected.
    
     
    

        		
    10e4e272ad6de50a36fedfa4335c719a5a7c9db6

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 

    












    
 





 
    
  
    
   
    



maubin




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
maubin


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-6.x (924bda6)