Fix up arguments to logging methods.

Review Request #12705 — Created Oct. 28, 2022 and submitted

Information

Review Board
release-6.x

Reviewers

We have a special logging formatter that is used to show info when a
django HttpRequest is part of the log record. Once upon a time, the
way of getting extra information into a log record was just to pass it
as additional kwargs to the log methods, but the modern, documented
way of doing it is to pass a single extra dict. This change fixes our
code up to use that. We also had several logging instances where we had
the request available but were not passing it to the log.

While I was auditing our log messages, I fixed up some other trivial
issues like formatting with args and indentation.

Ran unit tests.

Summary ID
Fix up arguments to logging methods.
We have a special logging formatter that is used to show info when a django `HttpRequest` is part of the log record. Once upon a time, the way of getting extra information into a log record was just to pass it as additional `kwargs` to the log methods, but the modern, documented way of doing it is to pass a single `extra` dict. This change fixes our code up to use that. We also had several logging instances where we had the request available but were not passing it to the log. While I was auditing our log messages, I fixed up some other trivial issues like formatting with args and indentation. Testing Done: Ran unit tests.
fceee1abc8169e81c189d171f185262af0b79ad8
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (633fe35)