flake8
-
rbintegrations/discord/tests.py (Diff revision 1) Show all issues -
rbintegrations/mattermost/tests.py (Diff revision 1) line too long (83 > 79 characters) Column: 80 Error code: E501
Review Request #12698 — Created Oct. 25, 2022 and submitted
Information | |
---|---|
chipx86 | |
rbintegrations | |
release-2.0.x | |
Reviewers | |
rbintegrations | |
When a new review was posted without body_top text and no comment, we
fail to set thebody
variable, causing a crash.While the crash is harmless, it does cause spurious issues in the logs.
This change fixes this, and improves the overall behavior in two ways:
1) If the body_top is "Ship It!", we now fall back to the first comment
(if available), rather than an empty string for the text.2) If a comment is not available, it will now fall back to
body_bottom
,
which wasn't being considered before.
Unit tests pass. The new tests previously exhibited the behavior reported
by a customer.
rbintegrations/discord/tests.py (Diff revision 1) |
---|
rbintegrations/mattermost/tests.py (Diff revision 1) |
---|
line too long (83 > 79 characters) Column: 80 Error code: E501
Fixed line length issues.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+566 -46) |