Summary

Improve posting reviews to chat services, and fix a crash on empty reviews.

Review Request #12698 — Created Oct. 25, 2022 and submitted Nov. 1, 2022, 10:14 p.m.

Information

Owner

chipx86

Repository

rbintegrations

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

When a new review was posted without body_top text and no comment, we
fail to set the body variable, causing a crash.

While the crash is harmless, it does cause spurious issues in the logs.

This change fixes this, and improves the overall behavior in two ways:

1) If the body_top is "Ship It!", we now fall back to the first comment
(if available), rather than an empty string for the text.

2) If a comment is not available, it will now fall back to body_bottom,
which wasn't being considered before.

Testing Done

Unit tests pass. The new tests previously exhibited the behavior reported
by a customer.

Commits

Summary	ID
Improve posting reviews to chat services, and fix a crash on empty reviews. When a new review was posted without body_top text and no comment, we fail to set the `body` variable, causing a crash. While the crash is harmless, it does cause spurious issues in the logs. This change fixes this, and improves the overall behavior in two ways: 1) If the body_top is "Ship It!", we now fall back to the first comment (if available), rather than an empty string for the text. 2) If a comment is not available, then it now falls back to `body_bottom`, which wasn't being considered before.	ec9bb60fd579ef86de7813e07c41f7091040dfee

Summary

Improve posting reviews to chat services, and fix a crash on empty reviews.

When a new review was posted without body_top text and no comment, we fail to set the `body` variable, causing a crash. While the crash is harmless, it does cause spurious issues in the logs. This change fixes this, and improves the overall behavior in two ways: 1) If the body_top is "Ship It!", we now fall back to the first comment (if available), rather than an empty string for the text. 2) If a comment is not available, then it now falls back to `body_bottom`, which wasn't being considered before.

ec9bb60fd579ef86de7813e07c41f7091040dfee

Issues

Description	From	Last Updated
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Oct. 25, 2022, 5:47 p.m.
line too long (83 > 79 characters) Column: 80 Error code: E501	reviewbot	Oct. 25, 2022, 5:47 p.m.

flake8 failed.

JSHint passed.

flake8

rbintegrations/discord/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```
rbintegrations/mattermost/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
line too long (83 > 79 characters)

Column: 80
Error code: E501
```

Change Summary:

Fixed line length issues.

Commits:

	Summary	ID
	Improve posting reviews to chat services, and fix a crash on empty reviews. When a new review was posted without body_top text and no comment, we fail to set the `body` variable, causing a crash. While the crash is harmless, it does cause spurious issues in the logs. This change fixes this, and improves the overall behavior in two ways: 1) If the body_top is "Ship It!", we now fall back to the first comment (if available), rather than an empty string for the text. 2) If a comment is not available, then it now falls back to `body_bottom`, which wasn't being considered before.	bb0a45ca25c1a9aebc8ba839395ed0c0d0dd4aed
	Improve posting reviews to chat services, and fix a crash on empty reviews. When a new review was posted without body_top text and no comment, we fail to set the `body` variable, causing a crash. While the crash is harmless, it does cause spurious issues in the logs. This change fixes this, and improves the overall behavior in two ways: 1) If the body_top is "Ship It!", we now fall back to the first comment (if available), rather than an empty string for the text. 2) If a comment is not available, then it now falls back to `body_bottom`, which wasn't being considered before.	ec9bb60fd579ef86de7813e07c41f7091040dfee

Diff:

Revision 2 (+566 -46)

Show changes

	rbintegrations/basechat/integration.py
	rbintegrations/discord/tests.py
	rbintegrations/mattermost/tests.py
	rbintegrations/slack/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (837b5b6)