Summary

Fix up some bad test data for diffviewer tests.

Review Request #12696 — Created Oct. 24, 2022 and submitted Oct. 25, 2022, 12:19 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We had a couple tests in the diffviewer module that were technically
including incorrect index lines for the diff being applied. We hadn't
noticed this because GNU patch is pretty good at applying patches even
when they don't quite match up perfectly, but Apple patch (which we're
not actually supporting) exposed these. This change fixes that up, just
for the sake of correctness.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix up some bad test data for diffviewer tests. We had a couple tests in the diffviewer module that were technically including incorrect index lines for the diff being applied. We hadn't noticed this because GNU patch is pretty good at applying patches even when they don't quite match up perfectly, but Apple patch (which we're not actually supporting) exposed these. This change fixes that up, just for the sake of correctness. Testing Done: Ran unit tests.	b571d916170688470af76ecd0da4d61a6524d1fe

Summary

Fix up some bad test data for diffviewer tests.

We had a couple tests in the diffviewer module that were technically including incorrect index lines for the diff being applied. We hadn't noticed this because GNU patch is pretty good at applying patches even when they don't quite match up perfectly, but Apple patch (which we're not actually supporting) exposed these. This change fixes that up, just for the sake of correctness. Testing Done: Ran unit tests.

b571d916170688470af76ecd0da4d61a6524d1fe

flake8 passed.

JSHint passed.

Change Summary:

One more

Commits:

	Summary	ID
	Fix up some bad test data for diffviewer tests. We had a couple tests in the diffviewer module that were technically including incorrect index lines for the diff being applied. We hadn't noticed this because GNU patch is pretty good at applying patches even when they don't quite match up perfectly, but Apple patch (which we're not actually supporting) exposed these. This change fixes that up, just for the sake of correctness. Testing Done: Ran unit tests.	c141ee5339910a1400879fc481a903a69f71abd5
	Fix up some bad test data for diffviewer tests. We had a couple tests in the diffviewer module that were technically including incorrect index lines for the diff being applied. We hadn't noticed this because GNU patch is pretty good at applying patches even when they don't quite match up perfectly, but Apple patch (which we're not actually supporting) exposed these. This change fixes that up, just for the sake of correctness. Testing Done: Ran unit tests.	b571d916170688470af76ecd0da4d61a6524d1fe

Diff:

Revision 2 (+6 -6)

Show changes

reviewboard/diffviewer/tests/test_forms.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (b81c47c)