Summary:

Split EmailTestHelper out from test_email_sending.py

Review Request #12693 — Created Oct. 20, 2022 and submitted Oct. 28, 2022, 1:10 p.m.

Information
Owner:	david
Repository:	Review Board
Branch:	release-6.x
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

We have a helper class that handles much of the setup required to test

that reviews and review requests send emails, but this was contained

within the test case file where it was used. I need to use it elsewhere,

so I've split it out into a new file to import from.

Testing Done

Used the helper from a new test file.

Commits

Summary
	Split EmailTestHelper out from test_email_sending.py

Screenshots

Issues

Description	From	Last Updated
blank line at end of file Column: 1 Error code: W391	reviewbot	Oct. 20, 2022, 11:27 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/notifications/tests/mixins.py (Diff revision 1)
Show all issues
```
blank line at end of file

Column: 1
Error code: W391
```

Commits:

	Summary
-		Split EmailTestHelper out from test_email_sending.py
+		Split EmailTestHelper out from test_email_sending.py

Diff:

Revision 2 (+226 -140)

Show changes

	reviewboard/notifications/tests/mixins.py
	reviewboard/notifications/tests/test_email_sending.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (b1e799d)