Plumb through trivial flag for non-reply review publishing.

Review Request #12692 — Created Oct. 20, 2022 and submitted

Information

Review Board
release-6.x

Reviewers

We have trivial flags that suppress e-mail notifications on review
request and review publish operations. Unfortunately, the review
operation plumbed this through for replies but not for initial reviews.
This made it send e-mails unexpectedly when calling
publish(trivial=True). This change plumbs that through the signal to
allow suppression of the emails. We still don't allow "trivial" review
publishing from the UI.

Used in conjunction with other changes.

Summary ID
Plumb through trivial flag for non-reply review publishing.
We have `trivial` flags that suppress e-mail notifications on review request and review publish operations. Unfortunately, the review operation plumbed this through for replies but not for initial reviews. This made it send e-mails unexpectedly when calling `publish(trivial=True)`. This change plumbs that through the signal to allow suppression of the emails. We still don't allow "trivial" review publishing from the UI. Testing Done: Used in conjunction with other changes.
51aef8d6583efa9caf95aa714f4a3a9411e805f0
Description From Last Updated

We've documented these wrong. Should be bool.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/reviews/signals.py (Diff revision 1)
     
     
     
     
     
     
    Show all issues

    We've documented these wrong. Should be bool.

    1. That's actually already been fixed in a change that I landed a couple days ago, and hadn't updated this one after reordering them.

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (c2bbc7c)
Loading...