Summary

Plumb through trivial flag for non-reply review publishing.

Review Request #12692 — Created Oct. 20, 2022 and submitted Oct. 28, 2022, 1:10 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We have trivial flags that suppress e-mail notifications on review
request and review publish operations. Unfortunately, the review
operation plumbed this through for replies but not for initial reviews.
This made it send e-mails unexpectedly when calling
publish(trivial=True). This change plumbs that through the signal to
allow suppression of the emails. We still don't allow "trivial" review
publishing from the UI.

Testing Done

Used in conjunction with other changes.

Commits

Summary	ID
Plumb through trivial flag for non-reply review publishing. We have `trivial` flags that suppress e-mail notifications on review request and review publish operations. Unfortunately, the review operation plumbed this through for replies but not for initial reviews. This made it send e-mails unexpectedly when calling `publish(trivial=True)`. This change plumbs that through the signal to allow suppression of the emails. We still don't allow "trivial" review publishing from the UI. Testing Done: Used in conjunction with other changes.	51aef8d6583efa9caf95aa714f4a3a9411e805f0

Summary

Plumb through trivial flag for non-reply review publishing.

We have `trivial` flags that suppress e-mail notifications on review request and review publish operations. Unfortunately, the review operation plumbed this through for replies but not for initial reviews. This made it send e-mails unexpectedly when calling `publish(trivial=True)`. This change plumbs that through the signal to allow suppression of the emails. We still don't allow "trivial" review publishing from the UI. Testing Done: Used in conjunction with other changes.

51aef8d6583efa9caf95aa714f4a3a9411e805f0

Issues