Fix a couple bugs in TestCase.create_many_review_requests.
Review Request #12687 — Created Oct. 18, 2022 and submitted
Our helper to create multiple review requests at once had a few bugs:
- First, the conditional for the
start_local_idargument was backwards,
setting the local ID to
Nonewhen a local site was present.
- Second, the code that went to update any existing
counts wasn't properly handling exceptions in the case that the profile
does not yet exist.
- Third, the summary wasn't being properly formatted with the index,
leading to all review requests having the same summary "Test Summary %s"
Ran some unit tests that made use of
Just to verify, all unit tests pass with the summary change?
Found and fixed one more issue.
Revision 2 (+18 -12)