Summary:

Fix a couple bugs in TestCase.create_many_review_requests.

Review Request #12687 — Created Oct. 18, 2022 and submitted Oct. 28, 2022, 12:31 p.m.

Description

Our helper to create multiple review requests at once had a few bugs:

First, the conditional for the start_local_id argument was backwards,
setting the local ID to None when a local site was present.
Second, the code that went to update any existing LocalSiteProfile
counts wasn't properly handling exceptions in the case that the profile
does not yet exist.
Third, the summary wasn't being properly formatted with the index,
leading to all review requests having the same summary "Test Summary %s"

Testing Done

Ran some unit tests that made use of create_many_review_requests with
with_local_site=True.

Commits

Summary
	Fix a couple bugs in TestCase.create_many_review_requests.

Screenshots

Issues

Description	From	Last Updated
Just to verify, all unit tests pass with the summary change?	chipx86	Oct. 26, 2022, 9:04 a.m.

flake8 passed.

JSHint passed.

Found and fixed one more issue.

~		Our helper to create multiple review requests at once had two bugs when
~		dealing with local sites. First, the conditional for the
~		`start_local_id` argument was backwards, setting the local ID to `None`.
~		Second, the code that went to update any existing `LocalSiteProfile`
~		counts wasn't properly handling exceptions in the case that the profile
	~	Our helper to create multiple review requests at once had a few bugs:
	~
	~	First, the conditional for the `start_local_id` argument was backwards, setting the local ID to `None` when a local site was present.
	~	Second, the code that went to update any existing `LocalSiteProfile` counts wasn't properly handling exceptions in the case that the profile does not yet exist.
	~	Third, the summary wasn't being properly formatted with the index, leading to all review requests having the same summary "Test Summary %s"
-		does not yet exist.