Split up reviews/views.py

Review Request #12684 — Created Oct. 14, 2022 and submitted

Information
david
Review Board
release-6.x
Reviewers
reviewboard 
The main reviews/views.py file was pretty huge, and was very difficult

to navigate. This change splits it up into a bunch of smaller files.


There are a couple trivial changes (adding some asserts, defining a

name attribute on BugTracker) in order to make type checkers a

bit happier, but otherwise this is purely moving things around.
Ran unit tests.
Summary 
Split up reviews/views.py
Description From Last Updated

Nice cleanup. Do we want to add these individual modules to the Python docs, or just keep the existing views.py? …

 chipx86chipx86

too many blank lines (3) Column: 1 Error code: E303

 reviewbotreviewbot

blank line at end of file Column: 1 Error code: W391

 reviewbotreviewbot

line too long (83 > 79 characters) Column: 80 Error code: E501

 reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
Review request changed

Commits:
Summary
- 
Split up reviews/views.py
+ 
Split up reviews/views.py

Diff:

Revision 2 (+5304 -4950)

Show changes

reviewboard/hostingsvcs/bugtracker.py
reviewboard/reviews/views.py
reviewboard/reviews/views/__init__.py
reviewboard/reviews/views/attachments.py
reviewboard/reviews/views/bug_trackers.py
reviewboard/reviews/views/diff_fragments.py
reviewboard/reviews/views/diffviewer.py
reviewboard/reviews/views/download_diff.py
7 more

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
maubin
maubin 
  1. Ship It!
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 







  2. 
 
    
  
  
    
  
   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Nice cleanup.
    

    Do we want to add these individual modules to the Python docs, or just keep the existing views.py? Probably the former.
    

    If the former, then the views.py needs to do __autodoc_excludes__ = __all__ or it'll end up duplicating definitions for all these.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 













  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to release-6.x (8612482)





 


 










  

 









     

    

   

  

  

   
   Loading...