flake8
failed.
JSHint
passed.
flake8
-
reviewboard/reviews/views/diff_fragments.py (Diff revision 1) Show all issues -
reviewboard/reviews/views/email.py (Diff revision 1) blank line at end of file Column: 1 Error code: W391
Split up reviews/views.py
Review Request #12684 — Created Oct. 14, 2022 and submitted
| Information | |
|---|---|
| david | |
| Review Board | |
| release-6.x | |
| Reviewers | |
| reviewboard | |
The main reviews/views.py file was pretty huge, and was very difficult
to navigate. This change splits it up into a bunch of smaller files.There are a couple trivial changes (adding some asserts, defining a
nameattribute onBugTracker) in order to make type checkers a
bit happier, but otherwise this is purely moving things around.
Ran unit tests.
| Summary | |
|---|---|
| Description | From | Last Updated |
|---|---|---|
|
Nice cleanup. Do we want to add these individual modules to the Python docs, or just keep the existing views.py? … |
 chipx86
|
|
|
too many blank lines (3) Column: 1 Error code: E303 |
 reviewbot
|
|
|
blank line at end of file Column: 1 Error code: W391 |
reviewbot
|
|
|
line too long (83 > 79 characters) Column: 80 Error code: E501 |
reviewbot
|
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+5304 -4950) |
|||||||||
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
reviewboard/reviews/views/__init__.py (Diff revision 2) line too long (83 > 79 characters) Column: 80 Error code: E501
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+5306 -4950) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Change Summary:
Add modules to docs, set
__autodoc_excludes__for forwarding module.
Commits: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+5334 -4950) |
|||||||||
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.