Split up reviews/views.py

Review Request #12684 — Created Oct. 14, 2022 and submitted

david
Review Board
release-6.x
reviewboard

The main reviews/views.py file was pretty huge, and was very difficult
to navigate. This change splits it up into a bunch of smaller files.

There are a couple trivial changes (adding some asserts, defining a
name attribute on BugTracker) in order to make type checkers a
bit happier, but otherwise this is purely moving things around.

Ran unit tests.

Summary
Split up reviews/views.py
Description From Last Updated

Nice cleanup. Do we want to add these individual modules to the Python docs, or just keep the existing views.py? …

chipx86chipx86

too many blank lines (3) Column: 1 Error code: E303

reviewbotreviewbot

blank line at end of file Column: 1 Error code: W391

reviewbotreviewbot

line too long (83 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
Review request changed

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Nice cleanup.

    Do we want to add these individual modules to the Python docs, or just keep the existing views.py? Probably the former.

    If the former, then the views.py needs to do __autodoc_excludes__ = __all__ or it'll end up duplicating definitions for all these.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (8612482)
Loading...