Summary

Finish transitioning to named loggers in Review Board.

Review Request #12680 — Created Oct. 11, 2022 and submitted Oct. 20, 2022, 10:24 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In order to have better context for log messages, we've been moving
things over to use named loggers instead of just relying on the methods
in the logging module. This change finishes up that transition for the
Review Board codebase.

Testing Done

Ran unit tests.

Commits

Summary	ID
Finish transitioning to named loggers in Review Board. In order to have better context for log messages, we've been moving things over to use named loggers instead of just relying on the methods in the `logging` module. This change finishes up that transition for the Review Board codebase. Testing Done: Ran unit tests.	4541633a5ed4503bce64e1c0bab0915b330e8f2c

Issues

Description	From	Last Updated
redefinition of unused 'logger' from line 10 Column: 1 Error code: F811	reviewbot	Oct. 11, 2022, 5 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)

Show all issues

redefinition of unused 'logger' from line 10

Column: 1
Error code: F811

Commits:

	Summary	ID
	Finish transitioning to named loggers in Review Board. In order to have better context for log messages, we've been moving things over to use named loggers instead of just relying on the methods in the `logging` module. This change finishes up that transition for the Review Board codebase. Testing Done: Ran unit tests.	a90b811338c97fabf2ca8826066f2326ffba2b57
	Finish transitioning to named loggers in Review Board. In order to have better context for log messages, we've been moving things over to use named loggers instead of just relying on the methods in the `logging` module. This change finishes up that transition for the Review Board codebase. Testing Done: Ran unit tests.	4541633a5ed4503bce64e1c0bab0915b330e8f2c

Diff:

Revision 2 (+268 -202)

Show changes

	reviewboard/attachments/mimetypes.py
	reviewboard/attachments/models.py
	reviewboard/hostingsvcs/beanstalk.py
	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/bugzilla.py
	reviewboard/hostingsvcs/codebasehq.py
	reviewboard/hostingsvcs/forms.py
	reviewboard/hostingsvcs/gitlab.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-6.x (291ce51)