Add JSON output to rbt review.
Review Request #12673 — Created Oct. 11, 2022 and updated
Information | |
---|---|
maubin | |
RBTools | |
release-4.x | |
Reviewers | |
rbtools | |
This adds JSON output to the
rbt review
command. The output contains
information relevant to the review, such as:
- The review ID.
- The review API URL.
- The review URL.
- The review status which can bedraft
,published
, ordiscarded
.
- The review request ID.
- The review request URL.When a comment subcommand is used, the following comment details are also
included in the output:
- The comment type which can bediff_comment
,file_attachment_comment
,
orgeneral_comment
.
- The comment ID.
- The comment API URL.During testing, a regression in Review Board 5.0's API was discovered
which broke thereviews
URI template on the Root List Resource. This breaks
the command in cases where a new review draft needs to be created. While the
API regression is being tracked and dealt with separately, this change allows
the command to work normally by accessing the reviews through the review
request resource instead of the root since we're fetching the review request
resource anyways in order to include its URL in the output.An upcoming change will add unit tests for the
rbt review
command.
Manually tested the command and all of its subcommands.
Summary |
---|

Summary: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Commits: |
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+84 -24) |