Summary

Add unit tests for git-p4.

Review Request #12649 — Created Sept. 27, 2022 and submitted Oct. 5, 2022, 6:06 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The git-p4 support in GitClient lacked any real testing, which meant
it regressed with Python 3. This also made it harder to iterate on. We
had some fantastic work in recent contributions to extend the features
of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be
written to prove the support works.

This change introduces unit tests that cover get_repository_info() and
diff() for git-p4. It avoids duplicating a lot of the core diff tests,
but does cover all the Perforce-specific operations and multi-commit
review requests.

There's also a bit of cleanup to related tests in this file, to keep
naming consistent.

This is a precursor to work for optimizing and future-proofing this
code.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	e1863406f17441097cf5ef986cb3a9c87a943e03

Summary

Add unit tests for git-p4.

The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.

e1863406f17441097cf5ef986cb3a9c87a943e03

Issues

Description	From	Last Updated
'typing.Any' imported but unused Column: 1 Error code: F401	reviewbot	Sept. 28, 2022, 1:05 a.m.
too many blank lines (2) Column: 5 Error code: E303	reviewbot	Sept. 28, 2022, 1:05 a.m.
Change to GitClient.diff.	maubin	Sept. 28, 2022, 3:01 p.m.
Change to GitClient.parse_revision_spec	maubin	Sept. 28, 2022, 3:02 p.m.
Needs a Version Added:	maubin	Sept. 28, 2022, 3:02 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
'typing.Any' imported but unused

Column: 1
Error code: F401
```
rbtools/clients/tests/test_git.py (Diff revision 1)
The issue has been resolved. Show all issues
```
too many blank lines (2)

Column: 5
Error code: E303
```

Change Summary:


Removed an extra blank line.
Removed an unused import.

Commits:

	Summary	ID
	Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	20fdbd4574e75859b174008fa646a1cc59ad8a70
	Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	cc09d7d26d855303afdf2a40e0e0ecf10245524c

Diff:

Revision 2 (+1096 -142)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed the content for a tests docstring.

Commits:

	Summary	ID
	Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	cc09d7d26d855303afdf2a40e0e0ecf10245524c
	Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	aa1bdf3bd44e423fe77cf5d4f1ce2ab5e7593c1a

Diff:

Revision 3 (+1096 -142)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/tests/test_git.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Change to GitClient.diff.
```
rbtools/clients/tests/test_git.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Change to GitClient.parse_revision_spec
```
rbtools/clients/tests/test_git.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Needs a Version Added:
```

Change Summary:

Fixed problems with test docstrings.

Commits:

	Summary	ID
	Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	aa1bdf3bd44e423fe77cf5d4f1ce2ab5e7593c1a
	Add unit tests for git-p4. The git-p4 support in `GitClient` lacked any real testing, which meant it regressed with Python 3. This also made it harder to iterate on. We had some fantastic work in recent contributions to extend the features of git-p4 diffs, but we couldn't reasonably ask for any unit tests to be written to prove the support works. This change introduces unit tests that cover `get_repository_info()` and `diff()` for git-p4. It avoids duplicating a lot of the core diff tests, but does cover all the Perforce-specific operations and multi-commit review requests. This is a precursor to work for optimizing and future-proofing this code.	e1863406f17441097cf5ef986cb3a9c87a943e03

Diff:

Revision 4 (+1108 -146)

Show changes

	rbtools/clients/tests/__init__.py
	rbtools/clients/tests/test_git.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (e79a649)