Deprecate is_valid_version() and remove all usage.

 






 

 


  Review Request #12645
  —
  Created Sept. 25, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
is_valid_version() is one of our older methods, intended to compare

tuples of integers together. This was from a type before we understood

Python well enough to know we could just compare tuples directly.


This change deprecates is_valid_version() in favor of just comparing

tuples, and updates all code to do so.

 








  


 
 

  
All unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Deprecate is_valid_version() and remove all usage.
     
`is_valid_version()` is one of our older methods, intended to compare
tuples of integers together. This was from a type before we understood
Python well enough to know we could just compare tuples directly.

This change deprecates `is_valid_version()` in favor of just comparing
tuples, and updates all code to do so.

    

   
  		
  2e85bbe15e40d23203766b860b0dda0237f7435f
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/clients/git.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/clients/tests/test_svn.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/utils/checks.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/utils/tests/test_checks.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...