Summary

Deprecate is_valid_version() and remove all usage.

Review Request #12645 — Created Sept. 25, 2022 and submitted Oct. 5, 2022, 6 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

is_valid_version() is one of our older methods, intended to compare
tuples of integers together. This was from a type before we understood
Python well enough to know we could just compare tuples directly.

This change deprecates is_valid_version() in favor of just comparing
tuples, and updates all code to do so.

Testing Done

All unit tests pass.

Commits

Summary	ID
Deprecate is_valid_version() and remove all usage. `is_valid_version()` is one of our older methods, intended to compare tuples of integers together. This was from a type before we understood Python well enough to know we could just compare tuples directly. This change deprecates `is_valid_version()` in favor of just comparing tuples, and updates all code to do so.	2e85bbe15e40d23203766b860b0dda0237f7435f

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (278df3f)