• 
      

    Update the Subversion client for type safety.

    Review Request #12637 — Created Sept. 24, 2022 and submitted

    Information

    RBTools
    release-4.x

    Reviewers

    This goes through nearly all the Subversion client code, ensuring
    function signatures, lists, and dictionaries all have types defined.

    This has helped uncover many cases where we were assuming values were
    not None or assuming values were the right type (such as a string
    instead of an integer).

    Logic has been rewritten in some cases to aid in type safety, such as
    when building a diff and dealing with a mixture of lists and generators.

    Unit tests pass.

    Summary ID
    Update the Subversion client for type safety.
    This goes through nearly all the Subversion client code, ensuring function signatures, lists, and dictionaries all have types defined. This has helped uncover many cases where we were assuming values were not `None` or assuming values were the right type (such as a string instead of an integer). Logic has been rewritten in some cases to aid in type safety, such as when building a diff and dealing with a mixture of lists and generators.
    04ce7a76a9dfb6b2df0f5e880b63ce589f21844c
    Description From Last Updated

    'typing.Any' imported but unused Column: 1 Error code: F401

    reviewbotreviewbot

    Mind updating this with the new Tuple syntax while you're in here?

    daviddavid
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    david
    1. 
        
    2. rbtools/clients/svn.py (Diff revision 1)
       
       
       
       
      Show all issues

      Mind updating this with the new Tuple syntax while you're in here?

    3. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (138694f)