Summary

Add support for a User.FullName SAML attribute

Review Request #12633 — Created Sept. 23, 2022 and submitted Sept. 29, 2022, 3:08 p.m.

Information

Owner

grim

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

If User.FirstName or User.LastName is not specified, we try to look for a
User.FullName attribute and split that on the first space to get a first and
last name.

This was necessary because some IdPs only let you specify a full name.

Testing Done

Applied this in our container build and tested it live at reviews.imfreedom.org using JetBrains Hub as the IdP.

Commits

Summary	ID
Add support for a User.FullName SAML attribute If User.FirstName or User.LastName is not specified, we try to look for a User.FullName attribute and split that on the first space to get a first and last name. This was necessary because some IdPs only let you specify a full name.	b4450a2a086cfb9a7b3690f392f28e3fffc614ad

Issues

Description	From	Last Updated
line too long (80 > 79 characters) Column: 80 Error code: E501	reviewbot	Sept. 24, 2022, midnight

flake8 failed.

JSHint passed.

flake8

reviewboard/accounts/sso/backends/saml/views.py (Diff revision 1)
Show all issues
```
line too long (80 > 79 characters)

Column: 80
Error code: E501
```

Change Summary:

fix line limit

Commits:

	Summary	ID
	Add support for a User.FullName SAML attribute If User.FirstName or User.LastName is not specified, we try to look for a User.FullName attribute and split that on the first space to get a first and last name. This was necessary because some IdPs only let you specify a full name.	895604e73f65f79ca440089beea60265acc1cb89
	Add support for a User.FullName SAML attribute If User.FirstName or User.LastName is not specified, we try to look for a User.FullName attribute and split that on the first space to get a first and last name. This was necessary because some IdPs only let you specify a full name.	b4450a2a086cfb9a7b3690f392f28e3fffc614ad

Diff:

Revision 2 (+40)

Show changes

reviewboard/accounts/sso/backends/saml/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (1de1cf6)