Summary

Add Subversion unit tests for diffing/patching empty files.

Review Request #12630 — Created Sept. 23, 2022 and submitted Sept. 28, 2022, 12:57 a.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

We have code in SVNClient for adding empty hunk info to added/deleted
empty files, instead of just providing Index: lines, but this never
had any test coverage.

To ensure we have proper Subversion diff coverage, this change adds
missing unit tests for diffs and patching, covering both the added and
deleted files.

This required a new commit in the test Subversion repository, adding an
empty file we could delete for these tests.

Testing Done

Unit tests pass.

Commits

Summary	ID
Add Subversion unit tests for diffing/patching empty files. We have code in `SVNClient` for adding empty hunk info to added/deleted empty files, instead of just providing `Index:` lines, but this never had any test coverage. To ensure we have proper Subversion diff coverage, this change adds missing unit tests for diffs and patching, covering both the added and deleted files. This required a new commit in the test Subversion repository, adding an empty file we could delete for these tests.	afeb090e2e633d8b28bdf506651dd6b68e0f0f70

Summary

Add Subversion unit tests for diffing/patching empty files.

We have code in `SVNClient` for adding empty hunk info to added/deleted empty files, instead of just providing `Index:` lines, but this never had any test coverage. To ensure we have proper Subversion diff coverage, this change adds missing unit tests for diffs and patching, covering both the added and deleted files. This required a new commit in the test Subversion repository, adding an empty file we could delete for these tests.

afeb090e2e633d8b28bdf506651dd6b68e0f0f70

flake8 passed.

JSHint passed.

Summary:

-	Add Subversion unit tests for empty files.
+	[WIP] Add Subversion unit tests for empty files.

Change Summary:


Updated to set default capabilities for empty files for the client, and updated tests accordingly.
Added tests for applying patches with empty files.

Summary:

-	[WIP] Add Subversion unit tests for empty files.
+	Add Subversion unit tests for diffing/patching empty files.

Description:

		We have code in `SVNClient` for adding empty hunk info to added/deleted
		empty files, instead of just providing `Index:` lines, but this never
		had any test coverage.

~		To ensure we have proper Subversion diff coverage, this change adds a
~		missing unit test, covering both the added and deleted files.
	~	To ensure we have proper Subversion diff coverage, this change adds
	~	missing unit tests for diffs and patching, covering both the added and
	+	deleted files.

		This required a new commit in the test Subversion repository, adding an
		empty file we could delete for these tests.

Commits:

	Summary	ID
	Add Subversion unit tests for empty files. We have code in `SVNClient` for adding empty hunk info to added/deleted empty files, instead of just providing `Index:` lines, but this never had any test coverage. To ensure we have proper Subversion diff coverage, this change adds a missing unit test, covering both the added and deleted files. This required a new commit in the test Subversion repository, adding an empty file we could delete for these tests.	121fc5919d5386c1204718500ee8b7e9abcee617
	Add Subversion unit tests for diffing/patching empty files. We have code in `SVNClient` for adding empty hunk info to added/deleted empty files, instead of just providing `Index:` lines, but this never had any test coverage. To ensure we have proper Subversion diff coverage, this change adds missing unit tests for diffs and patching, covering both the added and deleted files. This required a new commit in the test Subversion repository, adding an empty file we could delete for these tests.	afeb090e2e633d8b28bdf506651dd6b68e0f0f70

Diff:

Revision 2 (+450 -12)

Show changes

	rbtools/clients/tests/test_svn.py
	rbtools/clients/tests/testdata/svn-repo/db/current
	rbtools/clients/tests/testdata/svn-repo/db/rep-cache.db-journal
	rbtools/clients/tests/testdata/svn-repo/db/txn-current
	rbtools/clients/tests/testdata/svn-repo/db/revprops/0/6
	rbtools/clients/tests/testdata/svn-repo/db/revs/0/6
	rbtools/clients/tests/testdata/svn-repo/db/transactions/.gitignore
	rbtools/clients/tests/testdata/svn-repo/db/txn-protorevs/.gitignore

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (5bb683c)