Fish Trophy

chipx86 got a fish trophy!

Fish Trophy

Update SOSClient to use new diff functionality.

Review Request #12621 — Created Sept. 22, 2022 and submitted

Information

RBTools
release-4.x

Reviewers

This reworks SOSClient to make use of the new diff tools and
UnifiedDiffWriter to generate diffs.

Now, we perform a diff of each file using the new diff tool support,
which simplifies logic and should provide wider compatibility as new
diff tool backends are implemented.

The resulting diff payload is then generated through a
UnifiedDiffWriter, giving us a consistent way of generating the
resulting diff payload for the DiffX file.

Unit tests have been updated to test diff execution in a way compatible
with multiple diff backends.

Unit tests pass.

Summary ID
Update SOSClient to use new diff functionality.
This reworks `SOSClient` to make use of the new diff tools and `UnifiedDiffWriter` to generate diffs. Now, we perform a diff of each file using the new diff tool support, which simplifies logic and should provide wider compatibility as new diff tool backends are implemented. The resulting diff payload is then generated through a `UnifiedDiffWriter`, giving us a consistent way of generating the resulting diff payload for the DiffX file. Unit tests have been updated to test diff execution in a way compatible with multiple diff backends.
4a9683f500de51b61f913a93d8ce1ed234c0a9d7
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (08b6255)