Update PerforceClient to use new diff functionality.
Review Request #12620 — Created Sept. 22, 2022 and submitted
PerforceClientto make use of the new diff tools and
UnifiedDiffWriterto generate diffs.
Now, the entire diff operation uses a single
generate the result. This is more efficient than building and joining a
bunch of lists of byte strings. It also helps create more standardized
output, taking care of issues like
\r\r\nnewlines in the process.
Diffs of files are performed using the new diff tool support, which
simplifies logic and should provide wider compatibility as new diff tool
backends are implemented.
A few fixes are also here for unsafe variable assumptions and dead code.
Unit tests pass.
Updated to use
UnifiedDiffWriter.write_file_headers, instead of calling both orig/modified header functions.
Revision 2 (+416 -296)
Checks run (2 succeeded)