Modernize and update rbtools.api.cache with types

Review Request #12606 — Created Sept. 15, 2022 and submitted

Information

RBTools
release-4.x

Reviewers

This change updates the rbtools.api.cache module to modernize the
code, getting rid of six, updating documentation, and adding type
annotations.

While I was in here, I also changed the clearcache command a bit to
make the command responsible for printing the success message instead of
the clear_cache method in the cache module. This allows us to use
self.stdout rather than just calling print.

  • Ran unit tests.
  • Posted some review requests.
  • Cleared my cache file.
Summary ID
Modernize and update rbtools.api.cache with types
This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.
b443fd4f1b2986508ae8917268c34c12dc6f4892
Description From Last Updated

line too long (81 > 79 characters) Column: 80 Error code: E501

reviewbotreviewbot

Might be nice to update the docs here by adding the Args:. Here and below for the other __init__ methods.

maubinmaubin
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
maubin
  1. 
      
  2. rbtools/api/cache.py (Diff revision 2)
     
     
    Show all issues

    Might be nice to update the docs here by adding the Args:. Here and below for the other __init__ methods.

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.x (eb5d89a)