Summary

Modernize and update rbtools.api.cache with types

Review Request #12606 — Created Sept. 15, 2022 and submitted Oct. 4, 2022, 8:36 a.m.

Information

Owner

david

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change updates the rbtools.api.cache module to modernize the
code, getting rid of six, updating documentation, and adding type
annotations.

While I was in here, I also changed the clearcache command a bit to
make the command responsible for printing the success message instead of
the clear_cache method in the cache module. This allows us to use
self.stdout rather than just calling print.

Testing Done


Ran unit tests.
Posted some review requests.
Cleared my cache file.

Commits

Summary	ID
Modernize and update rbtools.api.cache with types This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.	b443fd4f1b2986508ae8917268c34c12dc6f4892

Summary

Modernize and update rbtools.api.cache with types

This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.

b443fd4f1b2986508ae8917268c34c12dc6f4892

Issues

Description	From	Last Updated
line too long (81 > 79 characters) Column: 80 Error code: E501	reviewbot	Sept. 15, 2022, 2:17 p.m.
Might be nice to update the docs here by adding the Args:. Here and below for the other __init__ methods.	maubin	Sept. 26, 2022, 1:55 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/cache.py (Diff revision 1)
The issue has been dropped. Show all issues
```
line too long (81 > 79 characters)

Column: 80
Error code: E501
```

Commits:

	Summary	ID
	Modernize and update rbtools.api.cache with types This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.	8af04151615e17a27344291e8cd269e26c7193d2
	Modernize and update rbtools.api.cache with types This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.	092c14b8d9702f2324eea3929a2df216ff3531b4

Diff:

Revision 2 (+538 -136)

Show changes

	rbtools/api/cache.py
	rbtools/commands/clearcache.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/api/cache.py (Diff revision 2)

The issue has been resolved. Show all issues

Might be nice to update the docs here by adding the Args:. Here and below for the other __init__ methods.

Commits:

	Summary	ID
	Modernize and update rbtools.api.cache with types This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.	092c14b8d9702f2324eea3929a2df216ff3531b4
	Modernize and update rbtools.api.cache with types This change updates the `rbtools.api.cache` module to modernize the code, getting rid of `six`, updating documentation, and adding type annotations. While I was in here, I also changed the `clearcache` command a bit to make the command responsible for printing the success message instead of the `clear_cache` method in the cache module. This allows us to use `self.stdout` rather than just calling `print`. Testing Done: - Ran unit tests. - Posted some review requests. - Cleared my cache file.	b443fd4f1b2986508ae8917268c34c12dc6f4892

Diff:

Revision 3 (+650 -144)

Show changes

	rbtools/api/cache.py
	rbtools/commands/clearcache.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (eb5d89a)