Add a flag on commands to indicate that diffing is required.
Review Request #12605 — Created Sept. 15, 2022 and submitted — Latest diff uploaded
Command.needs_diffs. If set to
instantiation will check if any required diff tools are available. This
will allow the command to fail early with useful instructions.
This is set on
Note that this does mean that
rbt postcan't be used if the matching
client doesn't have an available diff tool. While it's technically
possible to use
rbt postwithout generating diffs, this isn't the
common case, and an available diff tool is a pretty reasonable
expectation to set.
Unit tests pass.
rbt postwith and without a working diff tool
for a client that requires it (Perforce, in my case), when used with an
upcoming change that adds these requirements to each client.