Allow set-siteconfig to set nonexisting keys.

Review Request #12596 — Created Sept. 13, 2022 and submitted — Latest diff uploaded

Information

Djblets
release-3.x

Reviewers

One annoying thing about the set-siteconfig management command is that
it would error out if you tried to set a key that wasn't already
explicitly set, even if a default was defined.

This change fixes that to allow setting those. We still do validation on
the "parent" keys when a setting path is drilling down into dicts, but
any leaf key can now be set.

Saw that I could now set items in siteconfig that I couldn't before.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Allow set-siteconfig to set nonexisting keys.
One annoying thing about the `set-siteconfig` management command is that it would error out if you tried to set a key that wasn't already explicitly set, even if a default was defined. This change fixes that to allow setting those. We still do validation on the "parent" keys when a setting path is drilling down into dicts, but any leaf key can now be set. Testing Done: Saw that I could now set items in siteconfig that I couldn't before.
98d715bdadc68dee717a94d72e5ac615d684239b David Trowbridge
djblets/siteconfig/management/commands/set-siteconfig.py
Loading...