Summary:

Allow set-siteconfig to set nonexisting keys.

Review Request #12596 — Created Sept. 13, 2022 and submitted Oct. 20, 2022, 10:23 a.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-3.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

One annoying thing about the set-siteconfig management command is that
it would error out if you tried to set a key that wasn't already
explicitly set, even if a default was defined.

This change fixes that to allow setting those. We still do validation on
the "parent" keys when a setting path is drilling down into dicts, but
any leaf key can now be set.

Testing Done

Saw that I could now set items in siteconfig that I couldn't before.

Commits

Summary
	Allow set-siteconfig to set nonexisting keys.

Screenshots

Issues

Description	From	Last Updated
I'm not sure how this works. If it's a new key, we get a NoneType. That will later crash when …	chipx86	Sept. 13, 2022, 12:12 p.m.

flake8 passed.

JSHint passed.

Fix it!

djblets/siteconfig/management/commands/set-siteconfig.py (Diff revision 1)

Show all issues

I'm not sure how this works.

If it's a new key, we get a NoneType. That will later crash when we do value_type(value).

Even if fixed, we don't have a way of setting integers, bools, etc.

I think we need to introduce a new type parameter and require that if setting a brand-new key.

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (d9b5ab6)