Add stale Ship It! styling and ARIA support to the Ship It!/Issues column.

Review Request #12593 — Created Sept. 12, 2022 and submitted

Information

Review Board
release-5.0.x

Reviewers

This updates the column to help identify when a review request has been
updated since receiving one or more Ship It! reviews. Now, if a review
request has been updated, the Ship It! count still remains, but the
color is grey instead of green, making it stand out and helping
reviewers know that they should look at the change again.

This also makes this column accessible. The indicator has an ARIA label
and title that convey the contents, with the icon and count being hidden
from the accessibility tree.

The text is localized based on the number of items, so there's a
different string for 1 Ship It or issue vs. many.

Tested with every combination of Ship It/Issue state and stale state,
verifying the tooltip and presentation.

Unit tests pass.

Summary ID
Add stale Ship It! styling and ARIA support to the Ship It!/Issues column.
This updates the column to help identify when a review request has been updated since receiving one or more Ship It! reviews. Now, if a review request has been updated, the Ship It! count still remains, but the color is grey instead of green, making it stand out and helping reviewers know that they should look at the change again. This also makes this column accessible. The indicator has an ARIA label and title that convey the contents, with the icon and count being hidden from the accessibility tree. The text is localized based on the number of items, so there's a different string for 1 Ship It or issue vs. many.
8711b6a7e657700da3fd873dfa88080410258e03

Description From Last Updated

Bug 2106

daviddavid

redefinition of unused 'test_render_data_with_many_open_issues' from line 3375 Column: 5 Error code: F811

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
david
  1. 
      
  2. Bug 2106

  3. 
      
chipx86
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (c3694d0)
Loading...