Summary

Add stale Ship It! styling and ARIA support to the Ship It!/Issues column.

Review Request #12593 — Created Sept. 12, 2022 and submitted Sept. 13, 2022, 11:38 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

2106

Depends On

Reviewers

Groups

reviewboard

People

Description

This also makes this column accessible. The indicator has an ARIA label
and title that convey the contents, with the icon and count being hidden
from the accessibility tree.

The text is localized based on the number of items, so there's a
different string for 1 Ship It or issue vs. many.

Testing Done

Tested with every combination of Ship It/Issue state and stale state,
verifying the tooltip and presentation.

Unit tests pass.

Commits

Summary	ID
Add stale Ship It! styling and ARIA support to the Ship It!/Issues column. This updates the column to help identify when a review request has been updated since receiving one or more Ship It! reviews. Now, if a review request has been updated, the Ship It! count still remains, but the color is grey instead of green, making it stand out and helping reviewers know that they should look at the change again. This also makes this column accessible. The indicator has an ARIA label and title that convey the contents, with the icon and count being hidden from the accessibility tree. The text is localized based on the number of items, so there's a different string for 1 Ship It or issue vs. many.	8711b6a7e657700da3fd873dfa88080410258e03

Summary

Add stale Ship It! styling and ARIA support to the Ship It!/Issues column.

This updates the column to help identify when a review request has been updated since receiving one or more Ship It! reviews. Now, if a review request has been updated, the Ship It! count still remains, but the color is grey instead of green, making it stand out and helping reviewers know that they should look at the change again. This also makes this column accessible. The indicator has an ARIA label and title that convey the contents, with the icon and count being hidden from the accessibility tree. The text is localized based on the number of items, so there's a different string for 1 Ship It or issue vs. many.

8711b6a7e657700da3fd873dfa88080410258e03

Files

Issues

Description	From	Last Updated
Bug 2106	david	Sept. 13, 2022, 11:37 p.m.
redefinition of unused 'test_render_data_with_many_open_issues' from line 3375 Column: 5 Error code: F811	reviewbot	Sept. 12, 2022, 2:56 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/datagrids/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

redefinition of unused 'test_render_data_with_many_open_issues' from line 3375

Column: 5
Error code: F811

Change Summary:

Fixed a duplicate test name and re-ran tests.

Commits:

	Summary	ID
	Add stale Ship It! styling and ARIA support to the Ship It!/Issues column. This updates the column to help identify when a review request has been updated since receiving one or more Ship It! reviews. Now, if a review request has been updated, the Ship It! count still remains, but the color is grey instead of green, making it stand out and helping reviewers know that they should look at the change again. This also makes this column accessible. The indicator has an ARIA label and title that convey the contents, with the icon and count being hidden from the accessibility tree. The text is localized based on the number of items, so there's a different string for 1 Ship It or issue vs. many.	9a608d0a348822be4fc26f4d2664e68398d3d23e
	Add stale Ship It! styling and ARIA support to the Ship It!/Issues column. This updates the column to help identify when a review request has been updated since receiving one or more Ship It! reviews. Now, if a review request has been updated, the Ship It! count still remains, but the color is grey instead of green, making it stand out and helping reviewers know that they should look at the change again. This also makes this column accessible. The indicator has an ARIA label and title that convey the contents, with the icon and count being hidden from the accessibility tree. The text is localized based on the number of items, so there's a different string for 1 Ship It or issue vs. many.	8711b6a7e657700da3fd873dfa88080410258e03

Diff:

Revision 2 (+776 -76)

Show changes

	reviewboard/datagrids/columns.py
	reviewboard/datagrids/tests.py
	reviewboard/static/rb/css/ui/datagrids.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

The issue has been resolved. Show all issues
```
Bug 2106
```

Bugs:

+	2106

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (c3694d0)