Summary:

Update SCMClient unit tests to check against run_process_exec().

Review Request #12580 — Created Sept. 5, 2022 and submitted Sept. 26, 2022, 1:30 a.m.

Information
Owner:	chipx86
Repository:	RBTools
Branch:	release-4.x
Bugs:
Depends On:
Reviewers
Groups:	rbtools
People:

Description

We're working to move away from execute() to run_process(), and as

part of that we've made execute() a wrapper around run_process().
To help with the porting effort, all SCMClient unit tests have been

updated to test against run_process_exec() (the hook point for

testing) instead of execute().

Testing Done

Unit tests pass.

Commits

Summary
	Update SCMClient unit tests to check against run_process_exec().

Screenshots

Issues

Description	From	Last Updated
This will need to be updated for the recent changes to the clearcase tests.	david	Sept. 14, 2022, 2:07 p.m.
Aren't we supposed to spy on run_process_exec? Here and the rest of this file.	david	Sept. 21, 2022, 7:15 p.m.

flake8 passed.

JSHint passed.

Show all issues

This will need to be updated for the recent changes to the clearcase tests.

Change Summary:

Updated the ClearCase tests for the latest directory diffing changes.

Commits:

	Summary
-		Update SCMClient unit tests to check against run_process_exec().
+		Update SCMClient unit tests to check against run_process_exec().

Diff:

Revision 2 (+2204 -1012)

Show changes

	rbtools/clients/tests/test_clearcase.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/clients/tests/test_sos.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/tests/test_git.py (Diff revision 2)

Show all issues

Aren't we supposed to spy on run_process_exec? Here and the rest of this file.

Change Summary:

Fixed Git unit tests to spy on run_process_exec().

Commits:

	Summary
-		Update SCMClient unit tests to check against run_process_exec().
+		Update SCMClient unit tests to check against run_process_exec().

Diff:

Revision 3 (+2208 -1012)

Show changes

	rbtools/clients/tests/test_clearcase.py
	rbtools/clients/tests/test_git.py
	rbtools/clients/tests/test_mercurial.py
	rbtools/clients/tests/test_sos.py
	rbtools/clients/tests/test_svn.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (b7f12fe)