Fix handling of errors with apply_patch() in SVN and Mercurial.
Review Request #12579 — Created Sept. 5, 2022 and submitted — Latest diff uploaded
apply_patch()
in both of these SCMClients failed to pass
ignore_errors=True
. This meant that that patch error handling would
never kick in, instead causing a more general error running the process.
This wasn't caught since unit tests (currently) spy onexecute()
and
override behavior, so error handling logic never kicks in.This change adds the missing
ignore_errors=True
to these.
Unit tests pass.
Also tested unit tests with the upcoming moves to
run_process()
.