Fix handling of errors with apply_patch() in SVN and Mercurial.

Review Request #12579 — Created Sept. 6, 2022 and submitted

Information

RBTools
release-4.x

Reviewers

apply_patch() in both of these SCMClients failed to pass
ignore_errors=True. This meant that that patch error handling would
never kick in, instead causing a more general error running the process.
This wasn't caught since unit tests (currently) spy on execute() and
override behavior, so error handling logic never kicks in.

This change adds the missing ignore_errors=True to these.

Unit tests pass.

Also tested unit tests with the upcoming moves to run_process().

Summary ID
Fix handling of errors with apply_patch() in SVN and Mercurial.
`apply_patch()` in both of these SCMClients failed to pass `ignore_errors=True`. This meant that that patch error handling would never kick in, instead causing a more general error running the process. This wasn't caught since unit tests (currently) spy on `execute()` and override behavior, so error handling logic never kicks in. This change adds the missing `ignore_errors=True` to these.
a505ae8798d55bbe2a6c3fe3f2827a7106811a23
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (edb9620)
Loading...