• 
      

    Add unit tests for CVS diffs.

    Review Request #12571 — Created Aug. 24, 2022 and submitted

    Information

    RBTools
    release-4.x

    Reviewers

    The CVS implementation lacked any unit tests around diffs. This change
    adds some tests, testing basic diff functionality, include_files=, and
    exclude_patterns=.

    Some of the diff logic was reordered to help be more readable, but no
    actual behavior has changed.

    Note that CVS has its own cvs diff, tool, so we don't directly depend
    on GNU diff.

    The data for the CVS repository in testdata will be committed in a
    separate change.

    Unit tests pass on Python 3.7-3.11.

    Summary ID
    Add unit tests for CVS diffs.
    The CVS implementation lacked any unit tests around diffs. This change adds some tests, testing basic diff functionality, `include_files=`, and `exclude_patterns=`. Some of the diff logic was reordered to help be more readable, but no actual behavior has changed. Note that CVS has its own `cvs diff`, tool, so we don't directly depend on GNU diff. The data for the CVS repository in `testdata` will be committed in a separate change.
    6abed651b64c6c3d20a266a27009428724924583
    maubin
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (f52acf4)