Summary

Update CVSClient for run_process(), type safety, and deprecations.

Review Request #12570 — Created Aug. 24, 2022 and submitted Sept. 15, 2022, 1:42 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Blocks

12571

Reviewers

Groups

rbtools

People

Description

CVSClient now uses run_process() instead of execute() for all
cvs interaction, giving us better type safety and safer execution.

All methods have been updated with type annotations, ensuring compliance
with BaseSCMClient requirements. Documentation has been updated where
appropriate.

Some deprecated calls have been updated, and dead code removed.

Testing Done

Unit tests pass on Python 3.7-3.11.

Commits

Summary	ID
Update CVSClient for run_process(), type safety, and deprecations. `CVSClient` now uses `run_process()` instead of `execute()` for all `cvs` interaction, giving us better type safety and safer execution. All methods have been updated with type annotations, ensuring compliance with `BaseSCMClient` requirements. Documentation has been updated where appropriate. Some deprecated calls have been updated, and dead code removed.	93adeef17aa99a6a9988e0d83e607b9a24f4aa67

Summary

Update CVSClient for run_process(), type safety, and deprecations.

`CVSClient` now uses `run_process()` instead of `execute()` for all `cvs` interaction, giving us better type safety and safer execution. All methods have been updated with type annotations, ensuring compliance with `BaseSCMClient` requirements. Documentation has been updated where appropriate. Some deprecated calls have been updated, and dead code removed.

93adeef17aa99a6a9988e0d83e607b9a24f4aa67

Issues

Description	From	Last Updated
Can take this out.	maubin	Sept. 12, 2022, 12:05 p.m.
We should document the AssertionErrors in the description.	maubin	Sept. 12, 2022, 12:05 p.m.

flake8 passed.

JSHint passed.

rbtools/clients/cvs.py (Diff revision 1)
Show all issues
```
Can take this out.
```

rbtools/clients/cvs.py (Diff revision 1)

Show all issues

We should document the AssertionErrors in the description.

chipx86 Sept. 12, 2022, 12:05 p.m.

If it's useful to the caller then it's worth doing (like a unit test helper method), but in this case it's truly an internal thing. A caller should never have to expect these to fire off, unless they've messed with what should be opaque state (in which case, tough).

Sort of like how we don't document Exception as a possible exception unless we're explicitly making that part of the API contract (random things can break internally, but that's not the caller's responsibility).

Change Summary:


Removed unused keyword arguments and moved them into **kwargs.

Commits:

	Summary	ID
	Update CVSClient for run_process(), type safety, and deprecations. `CVSClient` now uses `run_process()` instead of `execute()` for all `cvs` interaction, giving us better type safety and safer execution. All methods have been updated with type annotations, ensuring compliance with `BaseSCMClient` requirements. Documentation has been updated where appropriate. Some deprecated calls have been updated, and dead code removed.	b2321c28ce4d53e4fcfed5f9dcd9eb9042875dee
	Update CVSClient for run_process(), type safety, and deprecations. `CVSClient` now uses `run_process()` instead of `execute()` for all `cvs` interaction, giving us better type safety and safer execution. All methods have been updated with type annotations, ensuring compliance with `BaseSCMClient` requirements. Documentation has been updated where appropriate. Some deprecated calls have been updated, and dead code removed.	93adeef17aa99a6a9988e0d83e607b9a24f4aa67

Diff:

Revision 2 (+154 -132)

Show changes

rbtools/clients/cvs.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (ea8b6bf)