Fix type issues in TFS support and add typing annotations everywhere.
Review Request #12566 — Created Aug. 24, 2022 and submitted
Information | |
---|---|
chipx86 | |
RBTools | |
release-4.x | |
Reviewers | |
rbtools | |
TFS lacked any unit tests prior to RBTools 4, and had numerous
type-related issues that broke on Python 3. Users could go back to
Python 2 on earlier versions, but that won't be the case any longer.This change fixes up all the known type issues. It also adds typing
annotations to all parts of the code, ensuring that we are using the
proper types.Documentation in parts have been updated as well to help keep things a
bit more maintainable.
Unit tests pass in Python 3.7-3.11.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
Can take this out. |
![]() |
|
I don't see a parent_key in SCMClientDiffResult. Did you mean parent_diff? |
![]() |
|
Should we mention anything about how this is the format of SCMClientRevisionSpec here? |
![]() |
|
Same parent_key comment as above. |
![]() |
|
Same parent_key comment as above. |
![]() |
|
Should we mention anything about how this is the format of SCMClientRevisionSpec here? |
![]() |

-
-
-
rbtools/clients/tfs.py (Diff revision 1) I don't see a
parent_key
inSCMClientDiffResult
. Did you meanparent_diff
? -
rbtools/clients/tfs.py (Diff revision 1) Should we mention anything about how this is the format of
SCMClientRevisionSpec
here? -
-
-
rbtools/clients/tfs.py (Diff revision 1) Should we mention anything about how this is the format of
SCMClientRevisionSpec
here?
Change Summary:
- Fixed several typos (
parent_key
->parent_diff
) - Removed unused argument docs.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+504 -472) |