Fix type issues in TFS support and add typing annotations everywhere.
Review Request #12566 — Created Aug. 24, 2022 and submitted
TFS lacked any unit tests prior to RBTools 4, and had numerous
type-related issues that broke on Python 3. Users could go back to
Python 2 on earlier versions, but that won't be the case any longer.This change fixes up all the known type issues. It also adds typing
annotations to all parts of the code, ensuring that we are using the
proper types.Documentation in parts have been updated as well to help keep things a
bit more maintainable.
Unit tests pass in Python 3.7-3.11.
Summary | ID |
---|---|
396acea0a341b5bca94f16b3415643df22b3a192 |
Description | From | Last Updated |
---|---|---|
Can take this out. |
maubin | |
I don't see a parent_key in SCMClientDiffResult. Did you mean parent_diff? |
maubin | |
Should we mention anything about how this is the format of SCMClientRevisionSpec here? |
maubin | |
Same parent_key comment as above. |
maubin | |
Same parent_key comment as above. |
maubin | |
Should we mention anything about how this is the format of SCMClientRevisionSpec here? |
maubin |
- Change Summary:
-
- Fixed several typos (
parent_key
->parent_diff
) - Removed unused argument docs.
- Fixed several typos (
- Commits:
-
Summary ID 15c9737ec9e683817bb7e14ad3302666fb4d6117 396acea0a341b5bca94f16b3415643df22b3a192 - Diff:
-
Revision 2 (+504 -472)