flake8
-
rbtools/clients/tests/test_tfs.py (Diff revision 1) Show all issues -
rbtools/clients/tests/test_tfs.py (Diff revision 1) 'rbtools.utils.process.RunProcessResult' imported but unused Column: 1 Error code: F401
Review Request #12565 — Created Aug. 24, 2022 and submitted
Information | |
---|---|
chipx86 | |
RBTools | |
release-4.x | |
Reviewers | |
rbtools | |
This updates the TFS wrapper classes to switch over from
execute()
to
run_process()
. This gives us greater type safety across TFS, which is
important in keeping this client implementation maintainable.All call sites now explicitly read either the byte stream or the Unicode
stream, depending on their needs. There's no longer a risk of expecting
one type and ending up with another.Unit tests have been updated to spy on
run_process_exec()
, which gives
us a safe, checked way of returning data for tests that guarantees
proper interpreration by TFS.
Unit tests pass on Python 3.7-3.11.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
'rbtools.utils.process.RunProcessError' imported but unused Column: 1 Error code: F401 |
![]() |
|
'rbtools.utils.process.RunProcessResult' imported but unused Column: 1 Error code: F401 |
![]() |
|
Can take this out. |
![]() |
|
This comment no longer applies. |
![]() |
|
Same here. |
![]() |
rbtools/clients/tests/test_tfs.py (Diff revision 1) |
---|
rbtools/clients/tests/test_tfs.py (Diff revision 1) |
---|
'rbtools.utils.process.RunProcessResult' imported but unused Column: 1 Error code: F401
Removed unused imports.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+670 -646) |
**kwargs
docstring.execute
-specific information.Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+682 -668) |