Add dependency checks for Plastic.

Review Request #12552 — Created Aug. 18, 2022 and submitted — Latest diff uploaded

Information

RBTools
release-4.x

Reviewers

This updates PlasticClient to add formal support for dependency
checks. PlasticClient.check_dependencies() now determines if cm is
installed.

PlasticClient.get_local_path() now calls this instead of checking for
dependencies itself, emitting a warning if dependencies haven't already
been checked via setup() or has_dependencies().

Unit tests for Plastic didn't previously exist. This change adds some
dependency check tests for it.

It's unclear whether Plastic still actually works today, unfortunately,
as this was a contribution that never received updates. However this is
at least a step toward actual testing.

Unit tests pass on Python 3.7-3.11.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Add dependency checks for Plastic.
This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.
1a80b65ac713229cf241a38299b7e38c1c3edd43 Christian Hammond
rbtools/clients/plastic.py
rbtools/clients/tests/test_plastic.py
Loading...