Summary

Add dependency checks for Plastic.

Review Request #12552 — Created Aug. 18, 2022 and submitted Aug. 23, 2022, 6:33 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This updates PlasticClient to add formal support for dependency
checks. PlasticClient.check_dependencies() now determines if cm is
installed.

PlasticClient.get_local_path() now calls this instead of checking for
dependencies itself, emitting a warning if dependencies haven't already
been checked via setup() or has_dependencies().

Unit tests for Plastic didn't previously exist. This change adds some
dependency check tests for it.

It's unclear whether Plastic still actually works today, unfortunately,
as this was a contribution that never received updates. However this is
at least a step toward actual testing.

Testing Done

Unit tests pass on Python 3.7-3.11.

Commits

Summary	ID
Add dependency checks for Plastic. This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.	e112e8454976d2be5ef9b27ffb18d8737e2befc7

Summary

Add dependency checks for Plastic.

This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.

e112e8454976d2be5ef9b27ffb18d8737e2befc7

Issues

Description	From	Last Updated
'rbtools.deprecation.RemovedInRBTools50Warning' imported but unused Column: 1 Error code: F401	reviewbot	Aug. 18, 2022, 10:46 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/tests/test_plastic.py (Diff revision 1)

The issue has been resolved. Show all issues

'rbtools.deprecation.RemovedInRBTools50Warning' imported but unused

Column: 1
Error code: F401

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Add dependency checks for Plastic. This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.	b540fd9dc05da7eeccf41748733a6582b4f0d4df
	Add dependency checks for Plastic. This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.	1a80b65ac713229cf241a38299b7e38c1c3edd43

Diff:

Revision 2 (+132 -6)

Show changes

	rbtools/clients/plastic.py
	rbtools/clients/tests/test_plastic.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed a copy/paste issue in a docstring.

Commits:

	Summary	ID
	Add dependency checks for Plastic. This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.	1a80b65ac713229cf241a38299b7e38c1c3edd43
	Add dependency checks for Plastic. This updates `PlasticClient` to add formal support for dependency checks. `PlasticClient.check_dependencies()` now determines if `cm` is installed. `PlasticClient.get_local_path()` now calls this instead of checking for dependencies itself, emitting a warning if dependencies haven't already been checked via `setup()` or `has_dependencies()`. Unit tests for Plastic didn't previously exist. This change adds some dependency check tests for it. It's unclear whether Plastic still actually works today, unfortunately, as this was a contribution that never received updates. However this is at least a step toward actual testing.	e112e8454976d2be5ef9b27ffb18d8737e2befc7

Diff:

Revision 3 (+132 -6)

Show changes

	rbtools/clients/plastic.py
	rbtools/clients/tests/test_plastic.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (57c82ad)