flake8
-
rbtools/clients/tests/test_plastic.py (Diff revision 1) Show all issues
Review Request #12552 — Created Aug. 18, 2022 and submitted
Information | |
---|---|
chipx86 | |
RBTools | |
release-4.x | |
Reviewers | |
rbtools | |
This updates
PlasticClient
to add formal support for dependency
checks.PlasticClient.check_dependencies()
now determines ifcm
is
installed.
PlasticClient.get_local_path()
now calls this instead of checking for
dependencies itself, emitting a warning if dependencies haven't already
been checked viasetup()
orhas_dependencies()
.Unit tests for Plastic didn't previously exist. This change adds some
dependency check tests for it.It's unclear whether Plastic still actually works today, unfortunately,
as this was a contribution that never received updates. However this is
at least a step toward actual testing.
Unit tests pass on Python 3.7-3.11.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
'rbtools.deprecation.RemovedInRBTools50Warning' imported but unused Column: 1 Error code: F401 |
![]() |
Removed an unused import.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+132 -6) |
Fixed a copy/paste issue in a docstring.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+132 -6) |