Add dependency checks for Plastic.
Review Request #12552 — Created Aug. 18, 2022 and submitted — Latest diff uploaded
This updates
PlasticClient
to add formal support for dependency
checks.PlasticClient.check_dependencies()
now determines ifcm
is
installed.
PlasticClient.get_local_path()
now calls this instead of checking for
dependencies itself, emitting a warning if dependencies haven't already
been checked viasetup()
orhas_dependencies()
.Unit tests for Plastic didn't previously exist. This change adds some
dependency check tests for it.It's unclear whether Plastic still actually works today, unfortunately,
as this was a contribution that never received updates. However this is
at least a step toward actual testing.
Unit tests pass on Python 3.7-3.11.
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
Commits
rbtools/clients/plastic.py |
---|
rbtools/clients/tests/test_plastic.py |
---|